New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow other language titles #1023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pulling down all the details for a series, pull down all the titles at once so we can choose which to display.
Store the new otherTitles field in the database. We need to use Moshi to convert from a Map<String,String> to a String and back due to Room not supporting maps.
Features
Bug FixesTests
Doc
Styles
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
Generated by 🚫 Danger |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1023 +/- ##
==========================================
+ Coverage 77.23% 77.51% +0.27%
==========================================
Files 152 156 +4
Lines 2223 2299 +76
Branches 247 259 +12
==========================================
+ Hits 1717 1782 +65
- Misses 425 430 +5
- Partials 81 87 +6
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to change how the titles are displayed, the preference options are:
The titles are all pulled from the backend, if a title is not available it falls back to the canonical title.
Closes #735