Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent LWC spam when using a shop. #152

Closed
andrewkm opened this issue Aug 7, 2018 · 3 comments
Closed

Prevent LWC spam when using a shop. #152

andrewkm opened this issue Aug 7, 2018 · 3 comments

Comments

@andrewkm
Copy link

andrewkm commented Aug 7, 2018

Is there / or can there be some sort of LWC integration + config option to prevent chest shop from shooting the "this chest is private" message every time a user use's the shop?

Our settings are as such:

#Do you want to protect shop chests with LWC?
PROTECT_CHEST_WITH_LWC: true
#Do you want to protect shop signs with LWC?
PROTECT_SIGN_WITH_LWC: true
#Should the chest's LWC protection be removed once the shop sign is destroyed? 
REMOVE_LWC_PROTECTION_AUTOMATICALLY: true

However we continue to get reports like this:
https://ecocitycraft.com/forum/threads/skyblock-server-suggestion-reduce-spam-for-sell-chests.177259/

Would be nice if you can add this to chest shop so LWC notification don't shoot for chestshop.

@Phoenix616
Copy link
Member

I really doubt that LWC's API supports selectively turning of these notifications but I will look into whether or not there is a workaround, maybe there is a way to get ChestShop to cancel the event before it reaches LWC or something.

A quick workaround to stop it for now would be to disable LWC's notifications for normal players (something I do on my server) and tell them to use /cinfo if they want that information.

@andrewkm
Copy link
Author

Alright thank you @Phoenix616
Let me know what you figure out :) and if it's possible on your end.

@Phoenix616
Copy link
Member

Phoenix616 commented Aug 29, 2018

Unfortunately there doesn't seem to be a way to stop that. LWC doesn't fire any event when it blocks an interaction nor does it respect the cancel state of the sign interaction. For me to be able to hide this message LWC would need to do one of those. ChestShop already cancels the PlayerInteractEvent when a shop is found so all LWC would really need to do is respect that and not check for protections/send a message in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants