Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AdvancedChests #411

Open
Kesims opened this issue Feb 19, 2021 · 5 comments
Open

Add support for AdvancedChests #411

Kesims opened this issue Feb 19, 2021 · 5 comments

Comments

@Kesims
Copy link

Kesims commented Feb 19, 2021

Is your feature request related to a problem? Please describe.

ChestShop is not compatible with the plugin. When you put ChestShop sign on advanced chest, it tells that chest is empty, even when there are items in chest.

Describe the solution you'd like

Add AdvancedChests hook, that would allow to use these chests for shop.

Additional context

link to the plugin: https://www.spigotmc.org/resources/%E2%AD%90advancedchests%E2%AD%90-unlimited-sizes-holograms-%E2%9C%A8upgrades-%E2%9C%85sells-%E2%9A%A1sorter-%E2%98%84%EF%B8%8F-compressor.79061/

I can buy you the plugin, so you can test it.. :)

@Kesims Kesims added the enhancement For addition requests label Feb 19, 2021
@Phoenix616
Copy link
Member

Seeing as it's a private/paid plugin and they don't seem to provide any maven artifact for developers it will be near impossible to add support for it directly to ChestShop unless the author start providing such an artifact to depend on it.

Technically speaking it would be best for them to implement such support (either in their plugin or in ChestShop) also I don't see why they made their plugin intentionally incompatible with literally every other plugin trying to get a container's inventory, they could "just" return more content with all the items in it to plugins querying it but I guess that go too much into modding?

@Kesims
Copy link
Author

Kesims commented Feb 19, 2021

Thanks for quick response!

You know, I am just "user", so I dont know that much about how this plugin is made... But dev of other plugins that I use (JetsMinions and JetsHoppers) was able to add combatibility. So I thought that the dev of AdvancedChest has some artifact or somenthing for other plugins... I will ask him about that and I will let u know :)

@Kesims
Copy link
Author

Kesims commented Feb 19, 2021

@vgrynch
Copy link

vgrynch commented Aug 12, 2023

Config file:
image

@vgrynch
Copy link

vgrynch commented Aug 12, 2023

This worked for the Hybrid server with Forge mods. I was able to use custom chests from other mods. Please, try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants