Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize the shops Buy (B) and Sell (S) identifier #449

Closed
magrigry opened this issue May 29, 2021 · 1 comment
Closed

Customize the shops Buy (B) and Sell (S) identifier #449

magrigry opened this issue May 29, 2021 · 1 comment
Labels
duplicate Issues that were already brought up enhancement For addition requests

Comments

@magrigry
Copy link

magrigry commented May 29, 2021

I would like to be able to have different and translated value for the Buy and Sell identifier on the third line of a Shop :

  • A short identifier
  • A long identifier

Here is an example of a configuration implementation that could handle this

identifier:

  # This option would be used to customize the identifier which is actually "S" IF there is only a sell price (to avoid line OverFlow)
  long_sell:
  - "Vente" # which mean "sell" in french

  # This option would be used to customize the identifier which is actually "S" IF the shop also have a buy price
  short_sell:
  - "V" # The first value of this list would be use by default
  - "S" # We can provide on other value to avoid breaking older shops
 
  long_buy:
  - "Achat" # which mean "buy" in french
 
  short_buy:
  - "A"
  - "B"

Short and long notation could support colors which could be pretty nice for players to check if it's a sell or buy shop with a quick look

image

@magrigry magrigry added the enhancement For addition requests label May 29, 2021
@Phoenix616
Copy link
Member

Phoenix616 commented May 29, 2021

Duplicate of #237

@Phoenix616 Phoenix616 added the duplicate Issues that were already brought up label May 29, 2021
@Phoenix616 Phoenix616 marked this as a duplicate of #237 May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues that were already brought up enhancement For addition requests
Projects
None yet
Development

No branches or pull requests

2 participants