-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iteminfo/Sign Clicking difference #493
Comments
Item NBT: Items.db: See attached |
That's indeed really odd behaviour. As far as I can tell that only happens with items that use nbt which isn't directly supported by Bukkit's inbuilt serialisation as they seem to result in different serialised strings each time which isn't really ideal. Not much that can be done in the plugin itself, this would need to be fixed in the server directly. This isn't a big issue though, the shops work just fine even if the IDs don't match up. (The actual items are still the same) |
I just tested this on latest Spigot and the issue doesn't occur there so this seems to be a bug in Paper. It seems to also be present in Paper 1.17 but maybe it gets fixed at some point after 1.18 isn't deemed experimental and old issues can be worked on. Also #468, #413 and #303 are probably caused by the same underlying issue seeing as they all use a spigot fork too. |
I looked a bit more into it and it looks like it is caused by the NBT data order not being guaranteed and this patch from Paper even increasing the frequency of that occuring. Also the issue might even occur on Spigot itself seeing as it relies on a HashMap which's NBT tag order is also not constant and might change at some point, it just seems to occur a lot less frequent. |
What is happening?
Create Admin Shop
have "?" as itemID (or Manually enter ID from /iteminfo)
Click Sign to propogate ItemID
Item ID incorrect (Or if manually entered, will change ID number)
ID Number for item is Spawner#6 (Glow Squid)
ID Number that Appears on sign, regardless if manual entry or clicking with item, becomes Spawner#7
What did you expect to happen?
Correct ItemID displayed
Item Bought correlates to Item IDd
Plugin Version
ChestShop version 3.12 (Build 307)
ChestShop version 3.12.1-SNAPSHOT (build 334)
Plugin Config
Config
Server Version
This server is running Paper version git-Paper-20 (MC: 1.18) (Implementing API version 1.18-R0.1-SNAPSHOT) (Git: 0cd411e) You are 37 version(s) behind Download the new version at: https://papermc.io/downloads Previous version: git-Paper-10 (MC: 1.18)
Server Log
Log
What other plugins are you running?
AdvancedRegionMarket
CoreProtect
Essentials
EssentialsProtect
GriefPrevention
LastLog
LuckPerms
NoMobGrief
PlaceholderAPI
RHLeafDecay
TAB
VAULT
WorldEdit
WorldGuard
WorldGuardExtraFlags
Agreements
Additional context
No response
The text was updated successfully, but these errors were encountered: