Added /cstoggle #33
Added /cstoggle #33
Conversation
/cstoggle needs improving before release. Currently have a 'should-be' functional method of disabling all forms of CS buy/sell spam. Issue is in the implementation of the /cstoggle others potion, pursuing a feasible fix.
|
Thanks for the pull request, seems to be mostly fine, however the project is coded in a style that requires braces in every case, could you just fix that and I will gladly merge it :) |
|
Oh, also please put the command inside plugin.yml file and, if you could, implement the "usage" (/cstoggle ?) in that file, instead of hard-coding it in the plugin. Thanks! |
|
Absolutely, noted. Will do, and get back to you. I'm still learning Java itself, for all intents and purposes. My background is in C++ and I've been putting this off too long. |
|
No problem, it's just a matter of style - I prefer to stick to one through the whole codebase. I'm the opposite - my background is in Java and I'm currently learning Python/C++/C# :) |
| @@ -38,7 +38,7 @@ protected static void sendBuyMessage(TransactionEvent event) { | |||
|
|
|||
| String price = Economy.formatBalance(event.getPrice()); | |||
|
|
|||
| if (Properties.SHOW_TRANSACTION_INFORMATION_CLIENT) { | |||
| if (Properties.SHOW_TRANSACTION_INFORMATION_CLIENT && !Toggle.isIgnoringOthersMessages()) { | |||
There was a problem hiding this comment.
You must pass the "Player" instance here as isIgnoringOthersMessages() takes the parameter Player player.
|
I'm going to be making my own code and creating a pull request for this. |
|
Acro, go ahead and use his code if it checks out, I've got a lot going on right now that stole my attention from this again. |
|
@Dagvir No problem, I actually merged his commits already, however thank to you both! |
/cstoggle needs improving before release. Currently have a 'should-be'
functional method of disabling all forms of CS buy/sell spam. Issue is
in the implementation of the /cstoggle others option, pursuing a
feasible fix.