Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacing, symbolic_min, symbolic_max, and symbolic_size return Constants #127

Closed
wants to merge 2 commits into from

Conversation

deckerla
Copy link
Member

@deckerla deckerla commented Jun 7, 2022

applying these methods on Dimension objects return Constants

@deckerla deckerla self-assigned this Jun 7, 2022
@deckerla deckerla force-pushed the spacing_constants branch 7 times, most recently from 5438174 to f62e3e0 Compare June 7, 2022 21:29
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

Merging #127 (0a1592c) into master (b489070) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0a1592c differs from pull request most recent head b7c0484. Consider uploading reports for the commit b7c0484 to get more accurate results

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files           1        1           
  Lines         649      651    +2     
=======================================
+ Hits          648      650    +2     
  Misses          1        1           
Impacted Files Coverage Δ
src/Devito.jl 99.84% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b489070...b7c0484. Read the comment docs.

…max, and symbolic_size methods on dimensions return Constants of type Float64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants