Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Collection overload #5

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Add missing Collection overload #5

merged 2 commits into from
Jun 8, 2021

Conversation

Andre601
Copy link

@Andre601 Andre601 commented Jun 8, 2021

(This PR-Template is shit)

Added the missing addItems(Collection<MessageEmbed>) and setItems(Collection<MessageEmbed>) from my original PR.

@Chew Chew merged commit 68ceb6e into Chew:master Jun 8, 2021
@Chew
Copy link
Owner

Chew commented Jun 8, 2021

1.20.1

@Andre601 Andre601 deleted the patch-2 branch June 9, 2021 16:45
@Andre601 Andre601 restored the patch-2 branch June 9, 2021 16:47
@Andre601
Copy link
Author

Andre601 commented Jun 9, 2021

1.20.1

For whatever reasons is that not included in this version.
I downloaded 1.20.1 but the overloads aren't there... You sure it pushed the proper update or are you waiting?
image

@Andre601 Andre601 deleted the patch-2 branch June 9, 2021 16:53
@Chew
Copy link
Owner

Chew commented Jun 9, 2021

I didn't pull first.. :(
1.20.1 for real now (I also forgot to bump the release but it dutifully overwrote 1.20.1 anyway)

@Andre601
Copy link
Author

Andre601 commented Jun 9, 2021

Still no luck (Maybe it takes time to validate the release or something? Is it Maven-like?)

Just push to 1.20.2 imo to fix this

@Chew
Copy link
Owner

Chew commented Jun 9, 2021

Alright, pushed that too (maven whyyy)

@Andre601
Copy link
Author

Andre601 commented Jun 9, 2021

Now it finally works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants