Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix ButtonEmbedPaginator finalAction #85

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

TheMather1
Copy link

@TheMather1 TheMather1 commented Apr 16, 2024

Pull Request

Pull Request Checklist

Please follow the following steps before opening this PR.

PRs that do not complete the checklist will be subject to denial for
missing information.

Pull Request Information

Check and fill in the blanks for all that apply:

  • My PR fixes a bug, error, or other issue with the library's codebase.
  • My PR is for the Menu module of the JDA-Utilities library.
  • My PR creates a new module for the JDA-Utilities library: ______.

Description

Prevent This interaction failed warning on successfully executed finalAction for ButtonEmbedPaginator.

@Chew
Copy link
Owner

Chew commented Jun 10, 2024

Do you have an example of this not working before/after?

@TheMather1
Copy link
Author

@Chew
Example how? I'm not sure what I could provide that would show anything meaningful.

Behavior's pretty clear. When the "stop" button is pressed, the interaction is not actually acknowledged. So if a custom finalAction is used that does not delete the message, it results in Discord displaying an interaction failed warning even if the action executes successfully.
This fix just acknowledges the interaction, preventing the warning.

Short of a screen recording of Discord showing this behavior, I'm not sure what you might be looking for.

@Chew
Copy link
Owner

Chew commented Jun 12, 2024

Oh I think I misunderstood, I thought this was an edge case. I'll test this later today, thank you!

@Chew Chew merged commit 9dd9857 into Chew:master Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants