-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a generator for single directory components #109
Conversation
I think I have fixed all the issues, except 3 from linting :
I'll need some guidance on that :) |
psalm needs to be informed about type of services that Drupal container returns. |
… fixture following the name change.
…salm issue about $vars being bools.
@PierrePaul This has been resolved in 3.x branch. You might need merge it into your branch. |
Psalm typically adds new violations with each release. The latest one 5.14.0 has been released just yesterday which brought some mess to this PR. This has been fixed in 3.x branch. Also I decided to pin the psalm version to make builds more predictable. I've just merged 3.x branch into your fork. It should resolve the psalm issues. |
Awesome thank you! So all done? |
Yes. I'll likely apply some minor changes to the code later to make it consistent with other generators. Also will check the generated SDC itself before the next release. Thank you for the hard work! |
I've removed the "status" question. The looks unlikely that someone will generate obsolete or deprecated components. And this is not a big deal to change this property in YML file after generation. Also replaced examples question with todo statement in the YML definition. The generator is included to DCG 3.2.0 release. |
Looking good! Do you want me to open up a MR to update DCG on the drush repo? |
That is not necessary. Composer installs the most recent stable release by default. |
Resolves issue https://www.drupal.org/project/cl_generator/issues/3365150
Add a generator for Single Directory Component with a first basic functional test.