Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated catch.hpp to 2.13.7 to support glibc 2.34+ #291

Closed
wants to merge 1 commit into from

Conversation

llowrey
Copy link

@llowrey llowrey commented Nov 13, 2021

Updating catch to 2.13.7 allows it to be built with glibc 2.34 and therefore on Fedora 35. This resolves the issues caused by the breaking change to MINSIGSTKSZ that was made in glibc 2.34.

Copy link
Contributor

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, was also unable to build on fedora 35. Applying this patch fixed the build error.

Would like to see this reviewed / merged

@github-actions
Copy link

'This PR has been flagged as stale due to no activity for over 60
days. It will not be automatically closed, but it has been given
a stale-pr label and should be manually reviewed.'

@github-actions
Copy link

'This PR has been flagged as stale due to no activity for over 60
days. It will not be automatically closed, but it has been given
a stale-pr label and should be manually reviewed.'

@github-actions
Copy link

'This PR has been flagged as stale due to no activity for over 60
days. It will not be automatically closed, but it has been given
a stale-pr label and should be manually reviewed.'

@hoffmang9
Copy link
Member

Closing in favor of #360

@hoffmang9 hoffmang9 closed this Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants