python-bindings: Release the python GIL whenever it makes sense #311
Conversation
xdustinface
force-pushed
the
pr-python-bindings-release-gil
branch
from
fe0db80
to
c8f397a
Compare
|
@arvidn @mariano54 Good points 👍 See here. |
| @@ -55,17 +45,19 @@ PYBIND11_MODULE(blspy, m) | |||
| throw std::invalid_argument( | |||
| "Length of bytes object not equal to PrivateKey::SIZE"); | |||
| } | |||
| py::gil_scoped_release release; | |||
| auto data_ptr = reinterpret_cast<const uint8_t *>(info.ptr); | |||
There was a problem hiding this comment.
info is still in python right?
There was a problem hiding this comment.
Hmm i assumed that the PyObject_GetBuffer in buffer::request copies it over but it might not from a quick deeper look at the code.. will review again tomorrow (or just move the release because it anyway doesn't really matter that much in this case)!
There was a problem hiding this comment.
Okay changed it, see 353a623. There were even some more cases were info.ptr was passed into Bytes and then into ::FromBytes which still would have been an access to that memory without the GIL (Bytes only stores the pointer).
|
Let's get this in after 1.3? |
Yeah sure good to me, im anyway waiting for 1.3 that i can start to bug again about all the GIL release PRs in the other repos too :) |
…-Network#311) * python-bindings: Release the python GIL where possible * python-bindings: Don't access `buffer_info::ptr` without the GIL
No description provided.