Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use _add_or_double instead of just _add and pin BLST to specific revision #391

Merged
merged 2 commits into from Jun 13, 2023
Merged

Use _add_or_double instead of just _add and pin BLST to specific revision #391

merged 2 commits into from Jun 13, 2023

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Jun 12, 2023 •
edited

Make sure to use_add_or_double rather than just _add. This properly supports creating an aggregated signature with the same sig.

Added test case that tests this functionality

Also, pin BLST to revision a8cd361c9f671577aeab3f074098443af92a53fc as very recent changes in origin/master cause some compilation issues.

@emlowe emlowe requested a review from wjblanke June 12, 2023 21:20
@emlowe
Copy link
Contributor Author

emlowe commented Jun 12, 2023

close and reopen for CI strangeness

@emlowe emlowe closed this Jun 12, 2023
@emlowe emlowe reopened this Jun 12, 2023
@emlowe emlowe changed the title Use _add_or_double instead of just _add Use _add_or_double instead of just _add and pin BLST to specific revision Jun 13, 2023
wjblanke
wjblanke approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@wallentx wallentx merged commit f243e18 into long_lived/blastwjb Jun 13, 2023
48 checks passed
@wallentx wallentx deleted the EL.add_or_double branch June 13, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emlowe @wjblanke @wallentx