Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some assembly source files that we'd need for the upcoming nightly build #412

Conversation

AmineKhaldi
Copy link
Contributor

This assists #410.

@AmineKhaldi AmineKhaldi self-assigned this Jun 21, 2023
@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 5332847405

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.584%

Totals Coverage Status
Change from base Build 5330282910: 0.0%
Covered Lines: 1624
Relevant Lines: 1717

💛 - Coveralls

@arvidn
Copy link
Contributor

arvidn commented Jun 21, 2023

is this supposed to fix this link error? it's not obvious that it would:
https://github.com/Chia-Network/bls-signatures/actions/runs/5329021747/jobs/9654285191?pr=410#step:3:233

@AmineKhaldi
Copy link
Contributor Author

is this supposed to fix this link error? it's not obvious that it would: https://github.com/Chia-Network/bls-signatures/actions/runs/5329021747/jobs/9654285191?pr=410#step:3:233

It shouldn't, this is related to the Windows side (where these asm files are used).

Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wallentx wallentx merged commit da41a92 into Chia-Network:main Jun 21, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants