Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject.toml instead of envvars for cibuildwheel #426

Merged
merged 4 commits into from Aug 8, 2023

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Aug 4, 2023

Puts most cibuildwheel configuration into pyproject.toml instead of using envvars in the github actions.

The rationale is that this makes it a little bit easier to build the wheel locally for debugging and testing as there is less configuration specific to GH actions

Note some of the envvars refer to GH action matrix items, so those remain in the GH workflow.

@coveralls-official
Copy link

coveralls-official bot commented Aug 4, 2023

Pull Request Test Coverage Report for Build 5802872593

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.649%

Totals Coverage Status
Change from base Build 5787343810: 0.0%
Covered Lines: 1645
Relevant Lines: 1738

💛 - Coveralls

@emlowe
Copy link
Contributor Author

emlowe commented Aug 7, 2023

close and re-open for CI

@emlowe emlowe closed this Aug 7, 2023
@emlowe emlowe reopened this Aug 7, 2023
@emlowe emlowe marked this pull request as ready for review August 7, 2023 21:50
Remove manual cmake steps
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wallentx wallentx merged commit cf1aa88 into main Aug 8, 2023
53 checks passed
@wallentx wallentx deleted the EL.cibw-experiment branch August 8, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants