Skip to content

Commit

Permalink
Upgraded ws to 8.17.1 and solved some issues (#2415)
Browse files Browse the repository at this point in the history
* Upgraded ws to 8.17.1 / 7.5.10

* Updated `webpack.react.babel.ts` to fix an issue where webpack tries to bundle browser version of `ws`
  • Loading branch information
ChiaMineJP committed Jun 24, 2024
1 parent 79ae095 commit c9f4e15
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 10 deletions.
20 changes: 11 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/gui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"unique-names-generator": "4.6.0",
"validator": "13.11.0",
"victory": "^36.6.11",
"ws": "8.4.2"
"ws": "8.17.1"
},
"devDependencies": {
"@babel/core": "7.22.10",
Expand Down
4 changes: 4 additions & 0 deletions packages/gui/webpack.react.babel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ export default {
'@mui/styled-engine': '@mui/styled-engine-sc',
crypto: 'crypto-browserify',
stream: 'stream-browserify',
// Use `ws` package for nodejs instead of `ws` package for browsers
// Without this alias, webpack will bundle `ws` package for browsers
// See https://github.com/Chia-Network/chia-blockchain-gui/pull/2413#issuecomment-2181012908
ws: require.resolve('ws'),
},
},
optimization: {
Expand Down

0 comments on commit c9f4e15

Please sign in to comment.