Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide clawback TXs while wallet is syncing #1951

Merged
merged 2 commits into from Jul 27, 2023

Conversation

zsolt-dev
Copy link
Contributor

I liked the Jeff's idea of hiding clawback TX while syncing.

I did it but it was still flickering. So I switched from isSyncing to isSynced and now it behaves much better, without flickering back&forth.

- there was a second where it could be claimed, while not synced
@zsolt-dev zsolt-dev requested a review from paninaro July 27, 2023 07:26
@paninaro paninaro merged commit 6139018 into release/2.0.0 Jul 27, 2023
14 checks passed
@paninaro paninaro deleted the zsolt/hide-clawback-tx-while-syncing branch July 27, 2023 18:16
@paninaro paninaro linked an issue Jul 27, 2023 that may be closed by this pull request
paninaro added a commit to Chia-Network/chia-blockchain that referenced this pull request Aug 7, 2023
* Use lerna 7.1.3 and nx 16.3.2 for macos 10.14 building by @emlowe in Chia-Network/chia-blockchain-gui#1917
* Fix "From" to "To" in wallet history by @zsolt-dev in Chia-Network/chia-blockchain-gui#1939
* Hide harvester tab in setting page in wallet mode by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1941
* Update "Clawback will be applied." warning by @zsolt-dev in Chia-Network/chia-blockchain-gui#1940
* Fixed add plot page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1954
* Add clawBackExpiration behind the expand TX row for clawback sender by @zsolt-dev in Chia-Network/chia-blockchain-gui#1950
* Hide clawback TXs while wallet is syncing by @zsolt-dev in Chia-Network/chia-blockchain-gui#1951
* Updated harvester setting page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1949
* Design fixes to Address Book by @lipalong in Chia-Network/chia-blockchain-gui#1957
* Hide GPU setting when it is not available by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1959
* `start_plotting` fix by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1958
* Icon updates by @paninaro in Chia-Network/chia-blockchain-gui#1967
* The label of `last block won` is now `Never` when there are no blocks… by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1971
* Hide temp folder selection on cudaplot by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1972
* Update Electron to 25.4.0 for security fixes by @paninaro in Chia-Network/chia-blockchain-gui#1976
* Plot filter value now is the function of height by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1979

**Full Changelog**: Chia-Network/chia-blockchain-gui@2.0.0-rc2...2.0.0-rc3
wallentx pushed a commit to Chia-Network/chia-blockchain that referenced this pull request Aug 7, 2023
Bump chia-blockchain-gui to 1314dc7cbe0b35d846f9cf279e842b662c4ad64c

* Use lerna 7.1.3 and nx 16.3.2 for macos 10.14 building by @emlowe in Chia-Network/chia-blockchain-gui#1917
* Fix "From" to "To" in wallet history by @zsolt-dev in Chia-Network/chia-blockchain-gui#1939
* Hide harvester tab in setting page in wallet mode by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1941
* Update "Clawback will be applied." warning by @zsolt-dev in Chia-Network/chia-blockchain-gui#1940
* Fixed add plot page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1954
* Add clawBackExpiration behind the expand TX row for clawback sender by @zsolt-dev in Chia-Network/chia-blockchain-gui#1950
* Hide clawback TXs while wallet is syncing by @zsolt-dev in Chia-Network/chia-blockchain-gui#1951
* Updated harvester setting page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1949
* Design fixes to Address Book by @lipalong in Chia-Network/chia-blockchain-gui#1957
* Hide GPU setting when it is not available by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1959
* `start_plotting` fix by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1958
* Icon updates by @paninaro in Chia-Network/chia-blockchain-gui#1967
* The label of `last block won` is now `Never` when there are no blocks… by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1971
* Hide temp folder selection on cudaplot by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1972
* Update Electron to 25.4.0 for security fixes by @paninaro in Chia-Network/chia-blockchain-gui#1976
* Plot filter value now is the function of height by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1979

**Full Changelog**: Chia-Network/chia-blockchain-gui@2.0.0-rc2...2.0.0-rc3
paninaro added a commit to Chia-Network/chia-blockchain that referenced this pull request Aug 9, 2023
* Use lerna 7.1.3 and nx 16.3.2 for macos 10.14 building by @emlowe in Chia-Network/chia-blockchain-gui#1917
* Fix "From" to "To" in wallet history by @zsolt-dev in Chia-Network/chia-blockchain-gui#1939
* Hide harvester tab in setting page in wallet mode by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1941
* Update "Clawback will be applied." warning by @zsolt-dev in Chia-Network/chia-blockchain-gui#1940
* Fixed add plot page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1954
* Add clawBackExpiration behind the expand TX row for clawback sender by @zsolt-dev in Chia-Network/chia-blockchain-gui#1950
* Hide clawback TXs while wallet is syncing by @zsolt-dev in Chia-Network/chia-blockchain-gui#1951
* Updated harvester setting page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1949
* Design fixes to Address Book by @lipalong in Chia-Network/chia-blockchain-gui#1957
* Hide GPU setting when it is not available by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1959
* `start_plotting` fix by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1958
* Icon updates by @paninaro in Chia-Network/chia-blockchain-gui#1967
* The label of `last block won` is now `Never` when there are no blocks… by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1971
* Hide temp folder selection on cudaplot by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1972
* Update Electron to 25.4.0 for security fixes by @paninaro in Chia-Network/chia-blockchain-gui#1976
* Plot filter value now is the function of height by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1979
* Fixed inconsistent step count by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1986
* Added compressed plot size texts by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1987

**Full Changelog**: Chia-Network/chia-blockchain-gui@2.0.0-rc2...2.0.0-rc4
wallentx pushed a commit to Chia-Network/chia-blockchain that referenced this pull request Aug 9, 2023
Bump chia-blockchaing-gui to 8f43234de14eeb04df4fca19cb1de1184ec47f53

* Use lerna 7.1.3 and nx 16.3.2 for macos 10.14 building by @emlowe in Chia-Network/chia-blockchain-gui#1917
* Fix "From" to "To" in wallet history by @zsolt-dev in Chia-Network/chia-blockchain-gui#1939
* Hide harvester tab in setting page in wallet mode by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1941
* Update "Clawback will be applied." warning by @zsolt-dev in Chia-Network/chia-blockchain-gui#1940
* Fixed add plot page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1954
* Add clawBackExpiration behind the expand TX row for clawback sender by @zsolt-dev in Chia-Network/chia-blockchain-gui#1950
* Hide clawback TXs while wallet is syncing by @zsolt-dev in Chia-Network/chia-blockchain-gui#1951
* Updated harvester setting page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1949
* Design fixes to Address Book by @lipalong in Chia-Network/chia-blockchain-gui#1957
* Hide GPU setting when it is not available by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1959
* `start_plotting` fix by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1958
* Icon updates by @paninaro in Chia-Network/chia-blockchain-gui#1967
* The label of `last block won` is now `Never` when there are no blocks… by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1971
* Hide temp folder selection on cudaplot by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1972
* Update Electron to 25.4.0 for security fixes by @paninaro in Chia-Network/chia-blockchain-gui#1976
* Plot filter value now is the function of height by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1979
* Fixed inconsistent step count by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1986
* Added compressed plot size texts by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1987

**Full Changelog**: Chia-Network/chia-blockchain-gui@2.0.0-rc2...2.0.0-rc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet temporarily shows old clawback tx while syncing [Bug]
2 participants