Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where plotNFT was not created after changing plotter #1997

Merged
merged 1 commit into from Aug 14, 2023

Conversation

ChiaMineJP
Copy link
Contributor

There is currently a bug where creating plotNFT is silently canceled after changing plotter.
The root cause is when changing plotter, form values are reset to plotter's default values.
Since the default value of create-nft request is false, even if filling plotNFT form, changing plotter reset the flag for creating plotNFT as false.

image

image

@ChiaMineJP ChiaMineJP added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Aug 12, 2023
@ChiaMineJP ChiaMineJP self-assigned this Aug 12, 2023
@ChiaMineJP
Copy link
Contributor Author

This PR also closes this issue Chia-Network/chia-blockchain#15980

@paninaro paninaro merged commit d87d64b into release/2.0.0 Aug 14, 2023
15 checks passed
@paninaro paninaro deleted the cmj.fix-create-new-plotnft branch August 14, 2023 19:34
paninaro added a commit to Chia-Network/chia-blockchain that referenced this pull request Aug 16, 2023
* Added texts for effective size by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1995
* Show `None` if plotNFT is not chosen in the add plot page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1992
* Fixed an issue where plotNFT was not created after changing plotter by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1997
* Fixed testnet faucet url by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1998

**Full Changelog**: Chia-Network/chia-blockchain-gui@2.0.0-rc4...2.0.0-rc5
wallentx pushed a commit to Chia-Network/chia-blockchain that referenced this pull request Aug 17, 2023
Bump chia-blockchain-gui to 623bcdbed1b8512cbbd056eab629eba20c694f20

* Added texts for effective size by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1995
* Show `None` if plotNFT is not chosen in the add plot page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1992
* Fixed an issue where plotNFT was not created after changing plotter by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1997
* Fixed testnet faucet url by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1998

**Full Changelog**: Chia-Network/chia-blockchain-gui@2.0.0-rc4...2.0.0-rc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants