Fix error when using file browser to import an offer #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove offer import background image
seeden
approved these changes
Oct 23, 2023
cmmarslender
pushed a commit
to Chia-Network/chia-blockchain
that referenced
this pull request
Nov 28, 2023
Fix typos by @omahs in Chia-Network/chia-blockchain-gui#2142 Fixed add plot directory button by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2199 fix by @paninaro in Chia-Network/chia-blockchain-gui#2202 Fix crash when previewing an offer created using WalletConnect by @paninaro in Chia-Network/chia-blockchain-gui#2201 Fix error when using file browser to import an offer by @paninaro in Chia-Network/chia-blockchain-gui#2203 Fix accidental mutation of the expiring offers defaults object by @paninaro in Chia-Network/chia-blockchain-gui#2214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2184
When performing a drag & drop, the File object contains both the
nameandpathproperties. When selecting a file from the open dialog, only thenameproperty is provided. This resulted in an error when attempting to stat the selected file's path, which would be""when using the file open dialog. The workaround according to the react-dropzone docs is to use FileReader to read the file contents for the returned File object.Also removes the offer import background image