Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The -o offer option for make_offer is broken by PR #17220 #17371

Closed
erniesc opened this issue Jan 21, 2024 · 1 comment
Closed

[Bug] The -o offer option for make_offer is broken by PR #17220 #17371

erniesc opened this issue Jan 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@erniesc
Copy link

erniesc commented Jan 21, 2024

What happened?

The changes for PR #17220 try to use the -o option for both the value option --offer and the boolean option --override.
When PR #17220 is applied to chia v2.1.3 or v2.1.4 the -o option for make_offer is no longer accepted as the offer amount as shown below.

chia wallet make_offer -o 1:0.000000000001 -p bump_fee_test.offer -m 0.00001 --override
Usage: chia wallet make_offer [OPTIONS]
Try 'chia wallet make_offer -h' for help.

Error: Missing option '-o' / '--offer'.

Using the --offer option instead of -o to specify the offer amount for the wallet make_offer command still works as expected.

The help for chia wallet make_offer also shows the duplication with PR #17220 applied.

-o, --offer TEXT A wallet id to offer and the amount to offer

-o, --override Creates offer without checking for unusual values

Version

2.1.4 with PR#17220

What platform are you using?

Linux

What ui mode are you using?

CLI

Relevant log output

No response

@wjblanke
Copy link
Contributor

Resolved in the next release, sorry for the inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants