Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Switch to use the Click framework #464

Closed
antazoey opened this issue Oct 14, 2020 · 10 comments · Fixed by #1002
Closed

[Enhancement] Switch to use the Click framework #464

antazoey opened this issue Oct 14, 2020 · 10 comments · Fixed by #1002
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@antazoey
Copy link

antazoey commented Oct 14, 2020

The CLI code would be much smaller, more manageable, and easier to add commands to if we make the switch to using the Click framework. Since this is python 3.7+ requirement, it seems like it would be compatible. It would be a major refactor however.

https://click.palletsprojects.com/en/7.x/

I am willing to make the migration myself (as I have experience using this framework) but without haste or priority, but on the weekends when I have time.

@mariano54
Copy link
Contributor

mariano54 commented Oct 15, 2020

I'm not opposed to this, we need to have a consistent way to add CLI programs, parameters, etc. The cli is quite messy right now. I would really like to have a CLI that is simple and fun to use

@mariano54 mariano54 added the enhancement New feature or request label Oct 15, 2020
@mariano54
Copy link
Contributor

@unparalleled-js do you happen to have some free time to help out with this? We could definitely use some help

@antazoey
Copy link
Author

Yes, I have some time probably Sunday this week... Here is one I made for in3 that can be roughly copied I presume.

@mariano54
Copy link
Contributor

Yeah that looks great!
We have the rpc clients which can be used to easily access the functions of the node and wallet. It would be cool to be able to send a transaction, and check farmer status using the CLI. (which only the UI can do atm)

@hoffmang9
Copy link
Member

Command line transaction management is underway here - fyi - #516

@antazoey
Copy link
Author

antazoey commented Dec 4, 2020

@mariano54
Copy link
Contributor

Look really cool, it's a big improvement over what we currently have now

@mariano54 mariano54 added the good first issue Good for newcomers label Feb 21, 2021
@mariano54
Copy link
Contributor

If anyone is interested in taking @unparalleled-js 's example and expanding it to the other cli programs, this would be an exellent contribution 👍

@jespino
Copy link
Contributor

jespino commented Feb 21, 2021

I'll give it a try

@mariano54
Copy link
Contributor

Finished by @jespino

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants