Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Set and enforce a consistent limit for number of wallets/plotNFTs #8550

Closed
emlowe opened this issue Sep 21, 2021 · 3 comments
Closed
Assignees
Labels
bug Something isn't working Sev4 Add to engineering backlog for future release

Comments

@emlowe
Copy link
Contributor

emlowe commented Sep 21, 2021

Currently, in some parts of the code there is an effective limit of 20 wallets (see https://github.com/Chia-Network/chia-blockchain/blob/main/chia/wallet/derive_keys.py#L65)

However, the UI allows creating many PlotNFTs, which each result in a new pooling wallet - this can soon result in a user ending up with more than 20 wallets, which then causes problems, particularly of course in find_authentication_sk() which will return None for any wallet_id > 20

This number should likely be parameterized in config.yaml and certainly enforced throughout the code to avoid users getting into problems.

@emlowe emlowe added the bug Something isn't working label Sep 21, 2021
@emlowe emlowe self-assigned this Sep 21, 2021
@paulhainsworth-chia paulhainsworth-chia added the Sev4 Add to engineering backlog for future release label Nov 11, 2021
@jack60612
Copy link
Contributor

This should be completed now.

@jack60612
Copy link
Contributor

Fixed by #9857

@jack60612
Copy link
Contributor

Was also improved on by #9922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Sev4 Add to engineering backlog for future release
Projects
None yet
Development

No branches or pull requests

3 participants