Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENTRYPOINT should be CMD #76

Closed
davidbarratt opened this issue May 30, 2021 · 5 comments
Closed

ENTRYPOINT should be CMD #76

davidbarratt opened this issue May 30, 2021 · 5 comments

Comments

@davidbarratt
Copy link
Contributor

The image should allow me to run any arbitrary command without starting up Chia itself, but since it's an entry point I cannot use docker run with a command

ENTRYPOINT ["bash", "./entrypoint.sh"]

@skweee
Copy link
Contributor

skweee commented Jun 1, 2021

This is exactly what "--entrypoint" is for:
docker run -it --entrypoint <your_command>

Please don't change the default entrypoint (as suggested in #77).

@davidbarratt
Copy link
Contributor Author

An ENTRYPOINT allows you to configure a container that will run as an executable.

https://docs.docker.com/engine/reference/builder/#entrypoint

So is chia an executable or is it something that runs. If it's the latter (which is how it's currently set up), it should be CMD

@davidbarratt
Copy link
Contributor Author

The main purpose of a CMD is to provide defaults for an executing container. These defaults can include an executable, or they can omit the executable, in which case you must specify an ENTRYPOINT instruction as well.

https://docs.docker.com/engine/reference/builder/#cmd

@github-actions
Copy link

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@github-actions
Copy link

'This issue was automatically closed because it has been flagged as stale and subsequently passed 7 days with no further activity.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants