Use CMD instead of ENTRYPOINT #77
Conversation
|
branch has conflicts. also, not 100% sure I agree with the idea that you must be able to run esoteric commands. Docker exec can drop you to shell on the container. |
I'll fix the conflicts. |
|
i would say that plotting from the container is at best a secondary concern. Not really a use case Id like to bake into the default setup. its easy enough imo to get into the container run time to start plotting. its a fair point. let me think through the orchestration changes I would need to make for GHA. |
davidbarratt
force-pushed
the
entrypoint-cmd
branch
from
707e9d4
to
20edcf0
Compare
|
'This PR has been flagged as stale due to no activity for over 60 |
There was a problem hiding this comment.
Looking through PRs today, and I think I do like how the accomplishes your goal of supporting chia commands without necessarily having chia running - Its a bit out of date with main, but if you can get it updated with latest changes from main and take a look at the proposed change below (and the associated problem with that tail) I can do some testing on the container this week to make sure it still works for all the existing cases.
| chia start farmer | ||
| fi | ||
|
|
||
| tail -f ~/.chia/mainnet/log/debug.log |
There was a problem hiding this comment.
| tail -f ~/.chia/mainnet/log/debug.log | |
| tail -f $CHIA_ROOT/log/debug.log |
This file doesn't necessarily exist right away either - I just tested a build of this locally (with latest main merged in) and I'm getting:
...
Daemon not started yet
Starting daemon
chia_harvester: started
chia_farmer: started
chia_full_node: started
chia_wallet: started
tail: cannot open '/root/.chia/mainnet/log/debug.log' for reading: No such file or directory
tail: no files remaining
Need to either go back to the previous while true; ... stuff, or else, maybe just touch $CHIA_ROOT/log/debug.log before trying to tail it
|
Closing in favor of #110 (includes these changes plus a few fixes and resolving conflicts) |
Fixes #76