Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure fullnode peer #179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ardikars
Copy link

@ardikars ardikars commented Dec 5, 2022

Motivation:
Adding isolated wallet container without touching main farming (farmer, fullnode, harvester, and wallet) container. Wallet can connect to farmer fullnode via docker network.

Changes:
Add chia configure --set-fullnode-peer "${fullnode_address}:${fullnode_port}" but it require to update chia-blockchain code as wall, changes here. If you think this changes can be applied I will create PR to chia-blockchain repository.

Result:
Faster wallet sync.

Reference:
sample-docker-compose

@Starttoaster Starttoaster self-assigned this Jan 3, 2023
@Starttoaster
Copy link
Contributor

This PR is dependent on code in a fork of chia-blockchain. Please make a PR to the chia-blockchain repo to have this new flag reviewed there. This PR can be reviewed when that flag makes it into a release of chia-blockchain. Thanks for the submission, by the way. I'm actually looking into making an alternative way to perform this configuration change (as well as others) for this container, but accomplishing it with a flag is also worthwhile imo.

@Starttoaster
Copy link
Contributor

Hey! Sorry for the apparent silence on the other PR. There's some internal discussions happening on what kinds of flags and how many of them should be supported by the chia CLI. In the meantime while the core engineering team figures that out, I set up a similar/alternative method that also accomplishes this. I personally like your use of the chia CLI to solve this problem, however, we recently uncovered a way to cut down on the chia-docker image size so we felt we could spare a few MB for yq, so this uses yq to set your full node peer in the config.yaml file. See this for documentation: https://github.com/Chia-Network/chia-docker/blob/main/readme.md#configure-full_node-peer

@CallumD
Copy link

CallumD commented Mar 20, 2024

@Starttoaster I believe the work around you kindly provided no longer works due to full_node_peer being changed into full_node_peers and being a list. For now I have been able to pin to the 2.1.1 version but hoping that this is updated at some point in the future to allow using this in more recent versions.

@CallumD
Copy link

CallumD commented Mar 20, 2024

looks like this functionality has been broken with this commit 029d93b @cmmarslender can we update this so the full node peer host(s) can also be provided as before?

@cmmarslender
Copy link
Contributor

looks like this functionality has been broken with this commit 029d93b @cmmarslender can we update this so the full node peer host(s) can also be provided as before?

Didn't see how this commit broke it at first, but I see now. Until this was added, chia was falling back to the old key names, and the other part of the entrypoint was still working. I'll get a PR in to update the full_node_peer command to use the new full_node_peers key

@cmmarslender
Copy link
Contributor

It does look like it should only break if network_port was defined somewhere, but either way, we should probably standardize on the new key.

@CallumD
Copy link

CallumD commented Mar 20, 2024

Amazing! Thanks for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants