Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wasm-bindgen to 0.2.92 #517

Merged
merged 1 commit into from
May 17, 2024
Merged

Bump wasm-bindgen to 0.2.92 #517

merged 1 commit into from
May 17, 2024

Conversation

Rigidity
Copy link
Contributor

Resolves the following warning about wasm-bindgen:

warning: the following packages contain code that will be rejected by a future version of Rust: wasm-bindgen v0.2.87
note: 
To solve this problem, you can try the following approaches:


- Some affected dependencies have newer versions available.
You may want to consider updating them to a newer version to see if the issue has been fixed.

wasm-bindgen v0.2.87 has the following newer versions available: 0.2.89, 0.2.90, 0.2.91, 0.2.92


- If the issue is not solved by updating the dependencies, a fix has to be
implemented by those dependencies. You can help with that by notifying the
maintainers of this problem (e.g. by creating a bug report) or by proposing a
fix to the maintainers (e.g. by creating a pull request):

  - wasm-bindgen@0.2.87
  - Repository: https://github.com/rustwasm/wasm-bindgen
  - Detailed warning command: `cargo report future-incompatibilities --id 2 --package wasm-bindgen@0.2.87`

- If waiting for an upstream fix is not an option, you can use the `[patch]`
section in `Cargo.toml` to use your own version of the dependency. For more
information, see:
https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section
        
note: this report can be shown with `cargo report future-incompatibilities --id 1`

@Rigidity Rigidity requested a review from arvidn May 17, 2024 03:45
@Rigidity
Copy link
Contributor Author

Rigidity commented May 17, 2024

If you're wondering why I removed the =, it's because we include wasm in the workspace, so it's included in Cargo.lock. Therefore this pin is redundant.

Copy link

Pull Request Test Coverage Report for Build 9122633253

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.163%

Totals Coverage Status
Change from base Build 9085195791: 0.0%
Covered Lines: 12010
Relevant Lines: 14270

💛 - Coveralls

@Rigidity Rigidity merged commit 3765b12 into main May 17, 2024
64 checks passed
@Rigidity Rigidity deleted the bindgen-update branch May 17, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants