Use ubuntu 22 runners #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
approved these changes
Aug 16, 2023
|
looks reasonable |
|
I suggest we just switch right now, since I'm convinced the problem is a runner issue, and whether we run this on 20 or 22 doesn't matter |
|
Alrighty, I think I'm convinced that while this is a questionable test of our artifacts (since it doesn't test them nor make any attempt to match their build environment) that changing from 20.04 to 22.04 isn't particularly worse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ubuntu-22 runners for the valgrind, ASAN, and TSAN tests - to avoid some strange new issue with ubuntu-20.
Generally it doesn't matter much where we run these memory fuzzers.