Skip to content

Commit

Permalink
Correctly handle fallback_version (#110)
Browse files Browse the repository at this point in the history
* Correctly handle fallback_version

* Totally forgot about the horrible windows workaround hack.
  • Loading branch information
hoffmang9 committed Mar 28, 2022
1 parent cb47a9b commit 5fa030f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 1 addition & 0 deletions pyproject.toml
Expand Up @@ -3,4 +3,5 @@ requires = ["setuptools>=42", "wheel", "setuptools_scm[toml]>=3.5.0", "pybind11"
build-backend = "setuptools.build_meta"

[tool.setuptools_scm]
fallback_version = "unknown-no-.git-directory"
local_scheme = "no-local-version"
2 changes: 0 additions & 2 deletions setup.py
Expand Up @@ -258,7 +258,6 @@ def build_extensions(self):
ext_modules=ext_modules,
cmdclass={"build_ext": BuildExt},
zip_safe=False,
use_scm_version={"fallback_version": "unknown-no-.git-directory"},
)
else:
build.sub_commands.append(("build_hook", lambda x: True)) # type: ignore
Expand All @@ -280,5 +279,4 @@ def build_extensions(self):
build_ext=CMakeBuild, install_hook=install_hook, build_hook=build_hook
),
zip_safe=False,
use_scm_version={"fallback_version": "unknown-no-.git-directory"},
)

0 comments on commit 5fa030f

Please sign in to comment.