Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use libpython3-dev instead of libpython3.8-dev #136

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jan 11, 2023

https://github.com/Chia-Network/chiavdf/actions/runs/3888384319/jobs/6635642471#step:3:16

E: Package 'libpython3.8-dev' has no installation candidate

I suspect that this broke with the transition of ubuntu-latest runners from Ubuntu 20.04 to 22.04. Unless we need 3.8 specifically then let's just take whatever the Ubuntu is giving us, or explicitly matrix across 'all' versions.

Draft for:

  • asking around for reasons we might need to be testing with 3.8 specifically

@hoffmang9
Copy link
Member

In the past this could pull 3.6 and not 3.7+. Should be fine now.

@altendky altendky marked this pull request as ready for review January 11, 2023 00:45
@altendky altendky mentioned this pull request Jan 11, 2023
@arvidn
Copy link
Contributor

arvidn commented Jan 11, 2023

@altendky libpython3 sounds like it might implement abi3 rather than version specific python. If it works, it sounds like an improvement for sure.

@altendky
Copy link
Contributor Author

I don't think that's related here. I think libpython3-dev is just the dev headers etc for the default Python 3 version rather than specifically the Python 3.8 version (that no longer is provided on the runner). Also, this is just changing for the workflow that builds against optimizations and sanitization options for testing.

@wallentx wallentx merged commit b1f23f4 into main Jan 11, 2023
@wallentx wallentx deleted the just_python3 branch January 11, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants