Convert NodePtr to a newtype rather than alias #333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encapsulates
NodePtr
as a separate type (with all necessary traits derived) rather than a type alias toi32
. This prevents typos or mistakes where you would useNodePtr
somewhere that expects a normali32
or vice versa. It also allows separate implementations of traits, for example encoding and decoding aNodePtr
with a CLVM allocator would be a no-op, whereasi32
is encoded as an atom.