Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLS and Secp operators #351

Merged
merged 2 commits into from
Dec 1, 2023
Merged

BLS and Secp operators #351

merged 2 commits into from
Dec 1, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 30, 2023 •
edited

soft-fork3 has activated and we can now enable BLS and Secp operators unconditionally.

They are already enabled unconditionally in chia-blockchain: Chia-Network/chia-blockchain#16819

In order to keep CI green, this PR also suppresses this warning:

GHSA-xphf-cx8h-7q9g

We only use OpenSSL for its SHA-256 implementation

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Nov 30, 2023 •
edited

Pull Request Test Coverage Report for Build 7059286876

  • 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 92.966%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/chia_dialect.rs 5 6 83.33%
Totals Coverage Status
Change from base Build 6989920772: -0.007%
Covered Lines: 5141
Relevant Lines: 5530
💛 - Coveralls

@arvidn arvidn force-pushed the enable-bls-secp branch 2 times, most recently from c21f6a2 to 10ed131 Compare December 1, 2023 11:07
@arvidn arvidn marked this pull request as ready for review December 1, 2023 11:17
@arvidn arvidn merged commit 7e83769 into main Dec 1, 2023
27 checks passed
@arvidn arvidn deleted the enable-bls-secp branch December 1, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmineKhaldi AmineKhaldi AmineKhaldi approved these changes

@richardkiss richardkiss Awaiting requested review from richardkiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arvidn @AmineKhaldi