NodePtr internal representation
#359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7451991707
💛 - Coveralls |
arvidn
force-pushed
the
nodeptr-repr
branch
2 times, most recently
from
aaf6999
to
5cd89f3
Compare
Rigidity
reviewed
Jan 8, 2024
…s 'type' and the bottom 26 bits for 'index'. Currently we use positive numbers for atoms and negative numbers for pairs. The new representation supports more types
Rigidity
approved these changes
Jan 8, 2024
richardkiss
reviewed
Jan 9, 2024
richardkiss
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the internal representation of
NodePtrto use the top 6 bits as "type" and the bottom 26 bits for "index". Currently we use positive numbers for atoms and negative numbers for pairs. The new representation supports more types.For example, we may want to have atoms in
BigInt,G1orG2formats internally. These could be new types.But perhaps the most important optimization this opens up is to have atoms point to external buffers. e.g. when running a program stored in a buffer, we could have atoms point directly into that buffer rather than copying everything into the
Allocatorobject first.