Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demote assert to debug_assert in NodePtr constructor #364

Merged
merged 1 commit into from
Jan 12, 2024
Merged

demote assert to debug_assert in NodePtr constructor #364

merged 1 commit into from
Jan 12, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jan 12, 2024 •
edited

this check degrades performance noticably

@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 7504627384

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 93.658%
Totals Coverage Status
Change from base Build 7464159735: -0.02%
Covered Lines: 5420
Relevant Lines: 5787
💛 - Coveralls

@arvidn arvidn merged commit 1cd97a3 into main Jan 12, 2024
27 checks passed
@arvidn arvidn deleted the nodeptr-assert branch January 12, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigidity Rigidity Rigidity approved these changes

@richardkiss richardkiss Awaiting requested review from richardkiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arvidn @Rigidity