-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Atom type to replace unsound API #377
Conversation
Pull Request Test Coverage Report for Build 7847070939Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one comment that I think might be important to address
This PR changes the way
a.atom(ptr)
works to return anAtom
type that can convert small integers to byte slices. This prevents a memory safety issue on the edge case where you exceed the temp vec length and references are left dangling.Overall, the performance is actually improved slightly for the majority of benchmarks.