Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial MSP430X Port. #52

Merged
merged 1 commit into from Apr 9, 2016
Merged

Initial MSP430X Port. #52

merged 1 commit into from Apr 9, 2016

Conversation

awygle
Copy link
Contributor

@awygle awygle commented Apr 8, 2016

This port includes hal, pal, serial, and st drivers. It supports both large and small model code and data for MSP430X-class CPUs. It has only been tested on the EXP430FR5969 LaunchPad board.

I wouldn't be surprised if there were some things that needed to be fixed before merging - any feedback is welcomed.

This port includes hal, pal, serial, and st drivers. It supports both
large and small model code and data for MSP430X-class CPUs. It has only
been tested on the EXP430FR5969 LaunchPad board.
@barthess
Copy link
Member

barthess commented Apr 8, 2016

@awygle
I can not test your code and send any feedback, but I can grant you write access if you will be a MSP430 maintainer.

Any thoughts from other repository users/contributers?

@utzig
Copy link
Member

utzig commented Apr 8, 2016

Is this based on the old MSP430 port or was it written from scratch?

@awygle
Copy link
Contributor Author

awygle commented Apr 8, 2016

This was written from scratch. I referenced the old MSP430 port a bit, as well as the AVR and STM32F0 ports, to figure out what the various APIs were supposed to do.

I'm definitely willing to maintain this port.

One non-technical thing I did want to ask - since this is in Contrib I made sure all the files are Apache 2.0 licensed and changed the copyright line from Giovanni to me, is that the right thing?

@utzig
Copy link
Member

utzig commented Apr 8, 2016

In contrib you can attribute everything to yourself I think. On main repo you can attribute most port specific and hal files to yourself but not core kernel files.

@awygle
Copy link
Contributor Author

awygle commented Apr 8, 2016

@utzig That's my understanding as well. Thanks for confirming.

@barthess barthess merged commit 2071319 into ChibiOS:master Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants