Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve notes related to CRAN rejection #220

Closed
geneorama opened this issue Aug 29, 2023 · 2 comments · Fixed by #222
Closed

Resolve notes related to CRAN rejection #220

geneorama opened this issue Aug 29, 2023 · 2 comments · Fixed by #222

Comments

@geneorama
Copy link
Member

According to the latest status there were some notes with our submission:
https://win-builder.r-project.org/incoming_pretest/RSocrata_1.7.13-7_20230825_224057/Windows/00check.log

Possibly misspelled words in DESCRIPTION:
  SoDA (7:35)

CRAN repository db overrides:
  X-CRAN-Comment: Archived on 2023-08-19 for repeated policy violation.

  On Internet access.

Found the following (possibly) invalid URLs:
  URL: https://gitter.im/Chicago/RSocrata (moved to https://app.gitter.im/#/room/#Chicago_RSocrata:gitter.im)
    From: README.md
    Status: 301
    Message: Moved Permanently
  URL: https://travis-ci.org/Chicago/RSocrata (moved to https://app.travis-ci.com/Chicago/RSocrata)
    From: README.md
    Status: 301
    Message: Moved Permanently

Although it's not technically correct, I think it will be fine to change SoDA to SODA to avoid the note.

I'm seeing a documentation warning from devtools (not R / CRAN) that "Warning: roxygen2 requires Encoding: "UTF-8"". This can be avoided by adding Encoding: UTF-8 to the description.

The Gitter and Travis CI URLs can be updated easily enough.

@geneorama
Copy link
Member Author

By the way, I did a fair amount of reading on Encoding: UTF-8 yesterday, and I'm not sure what the implications are of adding that to the DESCRIPTION. In my tests it was harmless, but the documentation https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Character-encoding-issues says that it's not required to be in UTF-8, but then it goes on to say that if the DESCRIPTION file isn't entire in ASCII then it is required? I wasn't sure how to test that or why it would be an issue for us, but the modification seems harmless.

@geneorama
Copy link
Member Author

geneorama commented Aug 29, 2023

Just for clarity, the email last Friday cited a timeout on 8/3
https://www.stats.ox.ac.uk/pub/bdr/Rblas/OpenBLAS/RSocrata.out

(that test is now skipped)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant