Fix badmatch, when using session and calling non existent action #536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
boss_controller_adapter_pmod:action/2
there was pattern match:{CMod, _} = ControllerInstance
, which assumes, thatControllerInstance
is two element tuple. Actually, it may be two element tuple{CMod, RequestWrapper}
or three element tuple{CMod, RequestWrapper, Session}
.The line was in the code, that handled actions which did not exist. It should return
undefined
, which causes returning 404, but because ofbadmatch
, it returned "Error in controller, see console.log for details".Changing pattern match to
CMod = element(1, ControllerInstance)
handles both cases and solves the problem.