Changed handling of decorators for classes in python 2.7 #9
Conversation
|
If you're happy with this solution, I would merge it and create a new release (0.2.3). I added some notes in the installation docs and the changelog about the new behavior. |
|
Nice ! Glancing at the diff this looks like the simpler try/catch solution I had in mind (with additional bells and whistles for backward-compat). Maybe I am missing something, but the snippet from #6 (comment) still raises an exception. Maybe you forgot to add the try/catch in |
This should solve using with_indent on classes in python2 #9 (comment)
|
Good points 😅 That's why I do not like copy-and-paste. This should be solved by the changes in 614796d |
|
I tried and the snippet mentioned above runs fine, thanks! |
| @self.ds | ||
| class Test2(object): | ||
| """docs""" | ||
| except AttributeError: |
There was a problem hiding this comment.
Just a side-comment (not saying that you should do it in this PR at all) but with pytest you can check expected exception like this:
with pytest.raises(AttributeError, 'the regex to check):
# code that raisesSee this for more details.
There was a problem hiding this comment.
Yep I know. I usually force myself to use the unittest framework only and there is no such thing for python 2, only for python 3.
There was a problem hiding this comment.
I usually force myself to use the unittest framework only
Interesting, do you mind to elaborate why?
There was a problem hiding this comment.
Sure. I mainly base my tests on unittest because it integrates well with the object-oriented structure of my packages. Additionally, since it is a built-in library, it is very stable and keeps my dependencies for running the tests low. Anyway, of course I use pytest as well, especially since it provides a better interfaces for running the tests. But if it is only for a minor thing (like here, where I would only use it for this single test method) I'd rather not rely on non built-in libraries. But for other packages with more extensive test suites, I indeed often rely on pytest but still use unittest as a basis
There was a problem hiding this comment.
OK thanks for the details. I have to say that there are so many nice things included in pytest both for writing tests and running the tests that you would have to pry it from my cold dead hands ...
This should finally solve the troubles with python 2 mentioned in #5 and #2.
Pinging @lesteve and @guillaumeeb because of their previous interest.