Execution Engine Improvements for Projections, Stitching and Federation

#5168

.editorconfig

@@ -45,7 +45,7 @@ dotnet_style_null_propagation = true:suggestion
 # Prefer "var" everywhere
 csharp_style_var_for_built_in_types = true:suggestion
 csharp_style_var_when_type_is_apparent = true:suggestion
-csharp_style_var_elsewhere = false
+csharp_style_var_elsewhere = true:suggestion
 
 # Prefer method-like constructs to have a block body
 csharp_style_expression_bodied_methods = false:none

.github/stale.yml

@@ -1,7 +1,7 @@
 # Number of days of inactivity before an issue becomes stale
 daysUntilStale: 120
 # Number of days of inactivity before a stale issue is closed
-daysUntilClose: 7
+daysUntilClose: 30
 # Issues with these labels will never be considered stale
 exemptLabels:
   - '📌 pinned'

.vscode/extensions.json

@@ -0,0 +1,6 @@
+{
+  "recommendations": [
+    "ms-azuretools.vscode-azurefunctions",
+    "ms-dotnettools.csharp"
+  ]
+}

.vscode/launch.json

@@ -0,0 +1,11 @@
+{
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "name": "Attach to .NET Functions",
+            "type": "coreclr",
+            "request": "attach",
+            "processId": "${command:azureFunctions.pickProcess}"
+        }
+    ]
+}

.vscode/settings.json

@@ -0,0 +1,8 @@
+{
+    "azureFunctions.deploySubpath": "templates/v12/function/bin/Release/net6.0/publish",
+    "azureFunctions.projectLanguage": "C#",
+    "azureFunctions.projectRuntime": "~4",
+    "debug.internalConsoleOptions": "neverOpen",
+    "azureFunctions.projectSubpath": "templates/v12/function",
+    "azureFunctions.preDeployTask": "publish (functions)"
+}

.vscode/tasks.json

@@ -10,9 +10,7 @@
             "args": [
                 "build",
                 "src/All.sln",
-                // Ask dotnet build to generate full paths for file names.
                 "/property:GenerateFullPaths=true",
-                // Do not generate summary otherwise it leads to duplicate errors in Problems panel
                 "/consoleloggerparameters:NoSummary"
             ],
             "group": "build",
@@ -28,9 +26,7 @@
             "args": [
                 "build",
                 "src/HotChocolate/Core",
-                // Ask dotnet build to generate full paths for file names.
                 "/property:GenerateFullPaths=true",
-                // Do not generate summary otherwise it leads to duplicate errors in Problems panel
                 "/consoleloggerparameters:NoSummary"
             ],
             "group": "build",
@@ -46,9 +42,7 @@
             "args": [
                 "build",
                 "src/HotChocolate/Core/test/Types.Analyzers.Tests",
-                // Ask dotnet build to generate full paths for file names.
                 "/property:GenerateFullPaths=true",
-                // Do not generate summary otherwise it leads to duplicate errors in Problems panel
                 "/consoleloggerparameters:NoSummary"
             ],
             "group": "build",
@@ -64,9 +58,7 @@
             "args": [
                 "build",
                 "src/StrawberryShake/CodeGeneration",
-                // Ask dotnet build to generate full paths for file names.
                 "/property:GenerateFullPaths=true",
-                // Do not generate summary otherwise it leads to duplicate errors in Problems panel
                 "/consoleloggerparameters:NoSummary"
             ],
             "group": "build",
@@ -82,16 +74,90 @@
             "args": [
                 "build",
                 "src/StrawberryShake/SourceGenerator",
-                // Ask dotnet build to generate full paths for file names.
                 "/property:GenerateFullPaths=true",
-                // Do not generate summary otherwise it leads to duplicate errors in Problems panel
                 "/consoleloggerparameters:NoSummary"
             ],
             "group": "build",
             "presentation": {
                 "reveal": "silent"
             },
             "problemMatcher": "$msCompile"
+        },
+        {
+            "label": "clean (functions)",
+            "command": "dotnet",
+            "args": [
+                "clean",
+                "/property:GenerateFullPaths=true",
+                "/consoleloggerparameters:NoSummary"
+            ],
+            "type": "process",
+            "problemMatcher": "$msCompile",
+            "options": {
+                "cwd": "${workspaceFolder}/templates/v12/function"
+            }
+        },
+        {
+            "label": "build (functions)",
+            "command": "dotnet",
+            "args": [
+                "build",
+                "/property:GenerateFullPaths=true",
+                "/consoleloggerparameters:NoSummary"
+            ],
+            "type": "process",
+            "dependsOn": "clean (functions)",
+            "group": {
+                "kind": "build",
+                "isDefault": true
+            },
+            "problemMatcher": "$msCompile",
+            "options": {
+                "cwd": "${workspaceFolder}/templates/v12/function"
+            }
+        },
+        {
+            "label": "clean release (functions)",
+            "command": "dotnet",
+            "args": [
+                "clean",
+                "--configuration",
+                "Release",
+                "/property:GenerateFullPaths=true",
+                "/consoleloggerparameters:NoSummary"
+            ],
+            "type": "process",
+            "problemMatcher": "$msCompile",
+            "options": {
+                "cwd": "${workspaceFolder}/templates/v12/function"
+            }
+        },
+        {
+            "label": "publish (functions)",
+            "command": "dotnet",
+            "args": [
+                "publish",
+                "--configuration",
+                "Release",
+                "/property:GenerateFullPaths=true",
+                "/consoleloggerparameters:NoSummary"
+            ],
+            "type": "process",
+            "dependsOn": "clean release (functions)",
+            "problemMatcher": "$msCompile",
+            "options": {
+                "cwd": "${workspaceFolder}/templates/v12/function"
+            }
+        },
+        {
+            "type": "func",
+            "dependsOn": "build (functions)",
+            "options": {
+                "cwd": "${workspaceFolder}/templates/v12/function/bin/Debug/net6.0"
+            },
+            "command": "host start",
+            "isBackground": true,
+            "problemMatcher": "$func-dotnet-watch"
         }
     ]
 }

src/HotChocolate/ApolloFederation/src/ApolloFederation/AnyType.cs

@@ -32,7 +32,7 @@ public AnyType()
     /// <param name="bind">
     /// Defines if this scalar shall bind implicitly to <see cref="SelectionSetNode"/>.
     /// </param>
-    public AnyType(NameString name, BindingBehavior bind = BindingBehavior.Explicit)
+    public AnyType(string name, BindingBehavior bind = BindingBehavior.Explicit)
         : base(name, bind)
     {
         Description = FederationResources.Any_Description;
@@ -108,7 +108,7 @@ public override bool TryDeserialize(object? resultValue, out object? runtimeValu
 
         if (resultValue is ObjectValueNode ovn)
         {
-            ObjectFieldNode? typeField = ovn.Fields.SingleOrDefault(
+            var typeField = ovn.Fields.SingleOrDefault(
                 field => field.Name.Value.EqualsOrdinal(TypeNameField));
 
             if (typeField?.Value is StringValueNode svn)

src/HotChocolate/ApolloFederation/src/ApolloFederation/Descriptors/EntityResolverDescriptor.cs

@@ -102,7 +102,7 @@ private void OnCompleteDefinition(ObjectTypeDefinition definition)
             throw new ArgumentNullException(nameof(method));
         }
 
-        MemberInfo member = method.TryExtractMember(true);
+        var member = method.TryExtractMember(true);
 
         if (member is MethodInfo m)
         {
@@ -131,7 +131,7 @@ public IObjectTypeDescriptor ResolveReferenceWith(MethodInfo method)
 
         var argumentBuilder = new ReferenceResolverArgumentExpressionBuilder();
 
-        FieldResolverDelegates resolver =
+        var resolver =
             Context.ResolverCompiler.CompileResolve(
                 method,
                 sourceType: typeof(object),

src/HotChocolate/ApolloFederation/src/ApolloFederation/FederationSchemaPrinter.cs

@@ -4,6 +4,7 @@
 using HotChocolate.ApolloFederation.Constants;
 using HotChocolate.Language;
 using HotChocolate.Types.Introspection;
+using HotChocolate.Utilities;
 using HotChocolate.Utilities.Introspection;
 
 namespace HotChocolate.ApolloFederation;
@@ -13,7 +14,7 @@ namespace HotChocolate.ApolloFederation;
 /// </summary>
 public static partial class FederationSchemaPrinter
 {
-    private readonly static HashSet<string> _builtInDirectives = new()
+    private static readonly HashSet<string> _builtInDirectives = new()
     {
         WellKnownTypeNames.External,
         WellKnownTypeNames.Requires,
@@ -53,25 +54,25 @@ private static DocumentNode SerializeSchema(ISchema schema)
         var context = new Context();
         var definitionNodes = new List<IDefinitionNode>();
 
-        foreach (DirectiveType directive in schema.DirectiveTypes)
+        foreach (var directive in schema.DirectiveTypes)
         {
             if (directive.IsPublic)
             {
                 context.DirectiveNames.Add(directive.Name);
             }
         }
 
-        foreach (INamedType namedType in GetRelevantTypes(schema))
+        foreach (var namedType in GetRelevantTypes(schema))
         {
-            if (TrySerializeType(namedType, context, out IDefinitionNode? definitionNode))
+            if (TrySerializeType(namedType, context, out var definitionNode))
             {
                 definitionNodes.Add(definitionNode);
             }
         }
 
-        foreach (DirectiveType directive in schema.DirectiveTypes)
+        foreach (var directive in schema.DirectiveTypes)
         {
-            if (!_builtInDirectives.Contains(directive.Name.Value) && directive.IsPublic)
+            if (!_builtInDirectives.Contains(directive.Name) && directive.IsPublic)
             {
                 definitionNodes.Add(SerializeDirectiveTypeDefinition(directive, context));
             }
@@ -83,7 +84,7 @@ private static DocumentNode SerializeSchema(ISchema schema)
     private static IEnumerable<INamedType> GetRelevantTypes(ISchema schema)
         => schema.Types
             .Where(IncludeType)
-            .OrderBy(t => t.Name.Value, StringComparer.Ordinal);
+            .OrderBy(t => t.Name, StringComparer.Ordinal);
 
     private static bool TrySerializeType(
         INamedType namedType,
@@ -136,7 +137,7 @@ private static IEnumerable<INamedType> GetRelevantTypes(ISchema schema)
 
         List<DirectiveNode>? directiveNodes = null;
 
-        foreach (IDirective directive in directives)
+        foreach (var directive in directives)
         {
             if (context.DirectiveNames.Contains(directive.Name))
             {
@@ -167,8 +168,8 @@ private static bool IncludeField(IOutputField field)
 
     private static bool IsApolloFederationType(INamedType type)
         => type is EntityType or ServiceType ||
-           type.Name.Equals(WellKnownTypeNames.Any) ||
-           type.Name.Equals(WellKnownTypeNames.FieldSet);
+           type.Name.EqualsOrdinal(WellKnownTypeNames.Any) ||
+           type.Name.EqualsOrdinal(WellKnownTypeNames.FieldSet);
 
     private static bool IsBuiltInType(INamedType type) =>
         IntrospectionTypes.IsIntrospectionType(type.Name) ||

src/HotChocolate/ApolloFederation/src/ApolloFederation/FederationTypeInterceptor.cs

@@ -114,9 +114,9 @@ private void CompleteReferenceResolver(ObjectTypeDefinition typeDef)
             else
             {
                 var expressions = new Stack<(Expression Condition, Expression Execute)>();
-                ParameterExpression context = Expression.Parameter(typeof(IResolverContext));
+                var context = Expression.Parameter(typeof(IResolverContext));
 
-                foreach (ReferenceResolverDefinition resolverDef in resolvers)
+                foreach (var resolverDef in resolvers)
                 {
                     Expression required = Expression.Constant(resolverDef.Required);
                     Expression resolver = Expression.Constant(resolverDef.Resolver);
@@ -126,7 +126,7 @@ private void CompleteReferenceResolver(ObjectTypeDefinition typeDef)
                 }
 
                 Expression current = Expression.Call(_invalid, context);
-                ParameterExpression variable = Expression.Variable(typeof(ValueTask<object?>));
+                var variable = Expression.Variable(typeof(ValueTask<object?>));
 
                 while (expressions.Count > 0)
                 {
@@ -185,11 +185,11 @@ private void CompleteReferenceResolver(ObjectTypeDefinition typeDef)
     {
         if (objectType.RuntimeType != typeof(object))
         {
-            IDescriptorContext descriptorContext = discoveryContext.DescriptorContext;
-            ITypeInspector typeInspector = discoveryContext.TypeInspector;
+            var descriptorContext = discoveryContext.DescriptorContext;
+            var typeInspector = discoveryContext.TypeInspector;
             var descriptor = ObjectTypeDescriptor.From(descriptorContext, objectTypeDefinition);
 
-            foreach (MethodInfo possibleReferenceResolver in
+            foreach (var possibleReferenceResolver in
                 objectType.RuntimeType.GetMethods(BindingFlags.Static | BindingFlags.Public))
             {
                 if (possibleReferenceResolver.IsDefined(typeof(ReferenceResolverAttribute)))
@@ -210,7 +210,7 @@ private void CompleteReferenceResolver(ObjectTypeDefinition typeDef)
         ObjectTypeDefinition objectTypeDefinition)
     {
         if (objectTypeDefinition.Directives.Any(
-            d => d.Reference is NameDirectiveReference { Name.Value: WellKnownTypeNames.Key }) ||
+            d => d.Reference is NameDirectiveReference { Name: WellKnownTypeNames.Key }) ||
             objectTypeDefinition.Fields.Any(f => f.ContextData.ContainsKey(WellKnownTypeNames.Key)))
         {
             _entityTypes.Add(objectType);
@@ -229,7 +229,7 @@ private void CompleteReferenceResolver(ObjectTypeDefinition typeDef)
             IReadOnlyList<ObjectFieldDefinition> fields = objectTypeDefinition.Fields;
             var fieldSet = new StringBuilder();
 
-            foreach (ObjectFieldDefinition? fieldDefinition in fields)
+            foreach (var fieldDefinition in fields)
             {
                 if (fieldDefinition.ContextData.ContainsKey(KeyMarker))
                 {
@@ -247,7 +247,7 @@ private void CompleteReferenceResolver(ObjectTypeDefinition typeDef)
 
             // register dependency to the key directive so that it is completed before
             // we complete this type.
-            foreach (DirectiveDefinition directiveDefinition in objectTypeDefinition.Directives)
+            foreach (var directiveDefinition in objectTypeDefinition.Directives)
             {
                 discoveryContext.Dependencies.Add(
                     new TypeDependency(
@@ -270,7 +270,7 @@ private void CompleteReferenceResolver(ObjectTypeDefinition typeDef)
         if (completionContext.Type is EntityType &&
             definition is UnionTypeDefinition unionTypeDefinition)
         {
-            foreach (ObjectType objectType in _entityTypes)
+            foreach (var objectType in _entityTypes)
             {
                 unionTypeDefinition.Types.Add(TypeReference.Create(objectType));
             }

src/HotChocolate/ApolloFederation/src/ApolloFederation/FieldSetType.cs

@@ -32,7 +32,7 @@ public FieldSetType() : this(WellKnownTypeNames.FieldSet)
     /// <param name="bind">
     /// Defines if this scalar shall bind implicitly to <see cref="SelectionSetNode"/>.
     /// </param>
-    public FieldSetType(NameString name, BindingBehavior bind = BindingBehavior.Explicit)
+    public FieldSetType(string name, BindingBehavior bind = BindingBehavior.Explicit)
         : base(name, bind)
     {
         Description = FederationResources.FieldsetType_Description;

src/HotChocolate/ApolloFederation/src/ApolloFederation/Helpers/ArgumentParser.cs

@@ -37,12 +37,12 @@ internal static class ArgumentParser
                 var current = path[i];
 
                 if (type is not IComplexOutputType complexType ||
-                    !complexType.Fields.TryGetField(current, out IOutputField? field))
+                    !complexType.Fields.TryGetField(current, out var field))
                 {
                     break;
                 }
 
-                foreach (ObjectFieldNode fieldValue in ((ObjectValueNode)valueNode).Fields)
+                foreach (var fieldValue in ((ObjectValueNode)valueNode).Fields)
                 {
                     if (fieldValue.Name.Value.EqualsOrdinal(current))
                     {
@@ -118,7 +118,7 @@ private static bool Matches(IValueNode valueNode, string[] path, int i)
             case SyntaxKind.ObjectValue:
                 var current = path[i];
 
-                foreach (ObjectFieldNode fieldValue in ((ObjectValueNode)valueNode).Fields)
+                foreach (var fieldValue in ((ObjectValueNode)valueNode).Fields)
                 {
                     if (fieldValue.Name.Value.EqualsOrdinal(current))
                     {