Add message to exception when enum conversion fails in Strawberry Sha…

…ke (#5713)
ChilliCream · Jan 30, 2023 · a7d1279 · a7d1279
1 parent 6c2b66e
commit a7d1279
Show file tree

Hide file tree

Showing 21 changed files with 56 additions and 54 deletions.
diff --git a/...trawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Generators/EnumParserGenerator.cs b/...trawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Generators/EnumParserGenerator.cs
@@ -57,7 +57,8 @@ public class EnumParserGenerator : CodeGenerator<EnumTypeDescriptor>
             .New()
             .SetReturn()
             .SetExpression(serializedValue)
-            .SetDefaultCase(ExceptionBuilder.Inline(TypeNames.GraphQLClientException));
+            .SetDefaultCase(ExceptionBuilder.Inline(TypeNames.GraphQLClientException)
+                .AddArgument($"$\"String value '{{serializedValue}}' can't be converted to enum {descriptor.Name}\""));
 
         foreach (var enumValue in descriptor.Values)
         {
@@ -77,7 +78,8 @@ public class EnumParserGenerator : CodeGenerator<EnumTypeDescriptor>
             SwitchExpressionBuilder.New()
                 .SetReturn()
                 .SetExpression(runtimeValue)
-                .SetDefaultCase(ExceptionBuilder.Inline(TypeNames.GraphQLClientException));
+                .SetDefaultCase(ExceptionBuilder.Inline(TypeNames.GraphQLClientException)
+                    .AddArgument($"$\"Enum {descriptor.Name} value '{{runtimeValue}}' can't be converted to string\""));
 
         foreach (var enumValue in descriptor.Values)
         {
@@ -88,4 +90,4 @@ public class EnumParserGenerator : CodeGenerator<EnumTypeDescriptor>
 
         return switchExpression;
     }
-}
+}
diff --git a/...ke/CodeGeneration/test/CodeGeneration.CSharp.Tests/Integration/MultiProfileTest.Client.cs b/...ke/CodeGeneration/test/CodeGeneration.CSharp.Tests/Integration/MultiProfileTest.Client.cs
@@ -1164,7 +1164,7 @@ public Episode Parse(global::System.String serializedValue)
                 "NEW_HOPE" => Episode.NewHope,
                 "EMPIRE" => Episode.Empire,
                 "JEDI" => Episode.Jedi,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum Episode")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -1174,7 +1174,7 @@ public Episode Parse(global::System.String serializedValue)
                 Episode.NewHope => "NEW_HOPE",
                 Episode.Empire => "EMPIRE",
                 Episode.Jedi => "JEDI",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum Episode value '{runtimeValue}' can't be converted to string")};
         }
     }
 

diff --git a/...neration/test/CodeGeneration.CSharp.Tests/Integration/StarWarsIntrospectionTest.Client.cs b/...neration/test/CodeGeneration.CSharp.Tests/Integration/StarWarsIntrospectionTest.Client.cs
@@ -2854,7 +2854,7 @@ public __TypeKind Parse(global::System.String serializedValue)
                 "INPUT_OBJECT" => __TypeKind.InputObject,
                 "LIST" => __TypeKind.List,
                 "NON_NULL" => __TypeKind.NonNull,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum __TypeKind")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -2869,7 +2869,7 @@ public __TypeKind Parse(global::System.String serializedValue)
                 __TypeKind.InputObject => "INPUT_OBJECT",
                 __TypeKind.List => "LIST",
                 __TypeKind.NonNull => "NON_NULL",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum __TypeKind value '{runtimeValue}' can't be converted to string")};
         }
     }
 

diff --git a/...ation/test/CodeGeneration.CSharp.Tests/StrawberryShake.CodeGeneration.CSharp.Tests.csproj b/...ation/test/CodeGeneration.CSharp.Tests/StrawberryShake.CodeGeneration.CSharp.Tests.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <IsPackable>false</IsPackable>

diff --git a/....CSharp.Tests/__snapshots__/EntityGeneratorTests.Generate_StarWars_Client_With_Defer.snap b/....CSharp.Tests/__snapshots__/EntityGeneratorTests.Generate_StarWars_Client_With_Defer.snap
@@ -741,7 +741,7 @@ namespace Foo.Bar
                 "NEW_HOPE" => Episode.NewHope,
                 "EMPIRE" => Episode.Empire,
                 "JEDI" => Episode.Jedi,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum Episode")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -751,7 +751,7 @@ namespace Foo.Bar
                 Episode.NewHope => "NEW_HOPE",
                 Episode.Empire => "EMPIRE",
                 Episode.Jedi => "JEDI",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum Episode value '{runtimeValue}' can't be converted to string")};
         }
     }
 

diff --git a/...Generation.CSharp.Tests/__snapshots__/EntityOrIdGeneratorTests.UnionWithNestedObject.snap b/...Generation.CSharp.Tests/__snapshots__/EntityOrIdGeneratorTests.UnionWithNestedObject.snap
@@ -500,7 +500,7 @@ namespace Foo.Bar
                 "MISSING_ARGUMENT" => ErrorCode.MissingArgument,
                 "INVALID_ARGUMENT" => ErrorCode.InvalidArgument,
                 "FAILED" => ErrorCode.Failed,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum ErrorCode")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -511,7 +511,7 @@ namespace Foo.Bar
                 ErrorCode.MissingArgument => "MISSING_ARGUMENT",
                 ErrorCode.InvalidArgument => "INVALID_ARGUMENT",
                 ErrorCode.Failed => "FAILED",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum ErrorCode value '{runtimeValue}' can't be converted to string")};
         }
     }
 

diff --git a/...test/CodeGeneration.CSharp.Tests/__snapshots__/ErrorGeneratorTests.Generate_NoErrors.snap b/...test/CodeGeneration.CSharp.Tests/__snapshots__/ErrorGeneratorTests.Generate_NoErrors.snap
@@ -283,7 +283,7 @@ namespace Foo.Bar
                 "NEW_HOPE" => Episode.NewHope,
                 "EMPIRE" => Episode.Empire,
                 "JEDI" => Episode.Jedi,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum Episode")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -293,7 +293,7 @@ namespace Foo.Bar
                 Episode.NewHope => "NEW_HOPE",
                 Episode.Empire => "EMPIRE",
                 Episode.Jedi => "JEDI",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum Episode value '{runtimeValue}' can't be converted to string")};
         }
     }
 

diff --git a/...Sharp.Tests/__snapshots__/NoStoreStarWarsGeneratorTests.Interface_With_Default_Names.snap b/...Sharp.Tests/__snapshots__/NoStoreStarWarsGeneratorTests.Interface_With_Default_Names.snap
@@ -283,7 +283,7 @@ namespace Foo.Bar
                 "NEW_HOPE" => Episode.NewHope,
                 "EMPIRE" => Episode.Empire,
                 "JEDI" => Episode.Jedi,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum Episode")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -293,7 +293,7 @@ namespace Foo.Bar
                 Episode.NewHope => "NEW_HOPE",
                 Episode.Empire => "EMPIRE",
                 Episode.Jedi => "JEDI",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum Episode value '{runtimeValue}' can't be converted to string")};
         }
     }
 

diff --git a/...Sharp.Tests/__snapshots__/NoStoreStarWarsGeneratorTests.Operation_With_Leaf_Argument.snap b/...Sharp.Tests/__snapshots__/NoStoreStarWarsGeneratorTests.Operation_With_Leaf_Argument.snap
@@ -283,7 +283,7 @@ namespace Foo.Bar
                 "NEW_HOPE" => Episode.NewHope,
                 "EMPIRE" => Episode.Empire,
                 "JEDI" => Episode.Jedi,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum Episode")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -293,7 +293,7 @@ namespace Foo.Bar
                 Episode.NewHope => "NEW_HOPE",
                 Episode.Empire => "EMPIRE",
                 Episode.Jedi => "JEDI",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum Episode value '{runtimeValue}' can't be converted to string")};
         }
     }
 

diff --git a/...Sharp.Tests/__snapshots__/NoStoreStarWarsGeneratorTests.Operation_With_Type_Argument.snap b/...Sharp.Tests/__snapshots__/NoStoreStarWarsGeneratorTests.Operation_With_Type_Argument.snap
@@ -337,7 +337,7 @@ namespace Foo.Bar
                 "NEW_HOPE" => Episode.NewHope,
                 "EMPIRE" => Episode.Empire,
                 "JEDI" => Episode.Jedi,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum Episode")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -347,7 +347,7 @@ namespace Foo.Bar
                 Episode.NewHope => "NEW_HOPE",
                 Episode.Empire => "EMPIRE",
                 Episode.Jedi => "JEDI",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum Episode value '{runtimeValue}' can't be converted to string")};
         }
     }
 

diff --git a/...CSharp.Tests/__snapshots__/OperationGeneratorTests.Generate_ChatClient_AllOperations.snap b/...CSharp.Tests/__snapshots__/OperationGeneratorTests.Generate_ChatClient_AllOperations.snap
@@ -2588,7 +2588,7 @@ namespace Foo.Bar
             {
                 "INCOMING" => Direction.Incoming,
                 "OUTGOING" => Direction.Outgoing,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum Direction")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -2597,7 +2597,7 @@ namespace Foo.Bar
             {
                 Direction.Incoming => "INCOMING",
                 Direction.Outgoing => "OUTGOING",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum Direction value '{runtimeValue}' can't be converted to string")};
         }
     }
 

diff --git a/...harp.Tests/__snapshots__/ScalarGeneratorTests.Complete_Schema_With_Uuid_And_DateTime.snap b/...harp.Tests/__snapshots__/ScalarGeneratorTests.Complete_Schema_With_Uuid_And_DateTime.snap
@@ -346,7 +346,7 @@ namespace Foo.Bar
                 "EDUCATION" => ExpenseCategory.Education,
                 "MISCELLANEOUS" => ExpenseCategory.Miscellaneous,
                 "PERSONAL_CARE" => ExpenseCategory.PersonalCare,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum ExpenseCategory")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -369,7 +369,7 @@ namespace Foo.Bar
                 ExpenseCategory.Education => "EDUCATION",
                 ExpenseCategory.Miscellaneous => "MISCELLANEOUS",
                 ExpenseCategory.PersonalCare => "PERSONAL_CARE",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum ExpenseCategory value '{runtimeValue}' can't be converted to string")};
         }
     }
 
@@ -398,7 +398,7 @@ namespace Foo.Bar
                 "DEBIT_CARD" => PaymentMethod.DebitCard,
                 "CREDIT_CARD" => PaymentMethod.CreditCard,
                 "PAY_PAL" => PaymentMethod.PayPal,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum PaymentMethod")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -410,7 +410,7 @@ namespace Foo.Bar
                 PaymentMethod.DebitCard => "DEBIT_CARD",
                 PaymentMethod.CreditCard => "CREDIT_CARD",
                 PaymentMethod.PayPal => "PAY_PAL",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum PaymentMethod value '{runtimeValue}' can't be converted to string")};
         }
     }
 

diff --git a/...ration.CSharp.Tests/__snapshots__/SchemaGeneratorTests.Create_UpdateMembers_Mutation.snap b/...ration.CSharp.Tests/__snapshots__/SchemaGeneratorTests.Create_UpdateMembers_Mutation.snap
@@ -593,7 +593,7 @@ namespace Foo.Bar
                 "VIEWER" => ProjectUserRoleType.Viewer,
                 "EDITOR" => ProjectUserRoleType.Editor,
                 "OWNER" => ProjectUserRoleType.Owner,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum ProjectUserRoleType")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -603,7 +603,7 @@ namespace Foo.Bar
                 ProjectUserRoleType.Viewer => "VIEWER",
                 ProjectUserRoleType.Editor => "EDITOR",
                 ProjectUserRoleType.Owner => "OWNER",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum ProjectUserRoleType value '{runtimeValue}' can't be converted to string")};
         }
     }
 

diff --git a/...Generation.CSharp.Tests/__snapshots__/SchemaGeneratorTests.FieldsWithUnderlineInName.snap b/...Generation.CSharp.Tests/__snapshots__/SchemaGeneratorTests.FieldsWithUnderlineInName.snap
@@ -2855,7 +2855,7 @@ namespace Foo.Bar
                 "MONTH" => TimeUnit.Month,
                 "QUARTER" => TimeUnit.Quarter,
                 "YEAR" => TimeUnit.Year,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum TimeUnit")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -2871,7 +2871,7 @@ namespace Foo.Bar
                 TimeUnit.Month => "MONTH",
                 TimeUnit.Quarter => "QUARTER",
                 TimeUnit.Year => "YEAR",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum TimeUnit value '{runtimeValue}' can't be converted to string")};
         }
     }
 
@@ -2898,7 +2898,7 @@ namespace Foo.Bar
                 "SUM" => Aggregation.Sum,
                 "MIN" => Aggregation.Min,
                 "MAX" => Aggregation.Max,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum Aggregation")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -2909,7 +2909,7 @@ namespace Foo.Bar
                 Aggregation.Sum => "SUM",
                 Aggregation.Min => "MIN",
                 Aggregation.Max => "MAX",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum Aggregation value '{runtimeValue}' can't be converted to string")};
         }
     }
 
@@ -2934,7 +2934,7 @@ namespace Foo.Bar
                 "NO_VALUE" => DataFlag.NoValue,
                 "VALID" => DataFlag.Valid,
                 "MISSING" => DataFlag.Missing,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum DataFlag")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -2944,7 +2944,7 @@ namespace Foo.Bar
                 DataFlag.NoValue => "NO_VALUE",
                 DataFlag.Valid => "VALID",
                 DataFlag.Missing => "MISSING",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum DataFlag value '{runtimeValue}' can't be converted to string")};
         }
     }
 

diff --git a/...n/test/CodeGeneration.CSharp.Tests/__snapshots__/SchemaGeneratorTests.HasuraMutation.snap b/...n/test/CodeGeneration.CSharp.Tests/__snapshots__/SchemaGeneratorTests.HasuraMutation.snap
@@ -3333,15 +3333,15 @@ namespace Foo.Bar
             return serializedValue switch
             {
                 "people_pkey" => People_constraint.PeoplePkey,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum People_constraint")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
         {
             return runtimeValue switch
             {
                 People_constraint.PeoplePkey => "people_pkey",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum People_constraint value '{runtimeValue}' can't be converted to string")};
         }
     }
 
@@ -3378,7 +3378,7 @@ namespace Foo.Bar
                 "firstName" => People_update_column.Firstname,
                 "id" => People_update_column.Id,
                 "lastName" => People_update_column.Lastname,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum People_update_column")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -3388,7 +3388,7 @@ namespace Foo.Bar
                 People_update_column.Firstname => "firstName",
                 People_update_column.Id => "id",
                 People_update_column.Lastname => "lastName",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum People_update_column value '{runtimeValue}' can't be converted to string")};
         }
     }
 
@@ -3415,15 +3415,15 @@ namespace Foo.Bar
             return serializedValue switch
             {
                 "cars_pkey" => Cars_constraint.CarsPkey,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum Cars_constraint")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
         {
             return runtimeValue switch
             {
                 Cars_constraint.CarsPkey => "cars_pkey",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum Cars_constraint value '{runtimeValue}' can't be converted to string")};
         }
     }
 
@@ -3460,7 +3460,7 @@ namespace Foo.Bar
                 "carName" => Cars_update_column.Carname,
                 "id" => Cars_update_column.Id,
                 "ownerId" => Cars_update_column.Ownerid,
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"String value '{serializedValue}' can't be converted to enum Cars_update_column")};
         }
 
         public global::System.Object Format(global::System.Object? runtimeValue)
@@ -3470,7 +3470,7 @@ namespace Foo.Bar
                 Cars_update_column.Carname => "carName",
                 Cars_update_column.Id => "id",
                 Cars_update_column.Ownerid => "ownerId",
-                _ => throw new global::StrawberryShake.GraphQLClientException()};
+                _ => throw new global::StrawberryShake.GraphQLClientException($"Enum Cars_update_column value '{runtimeValue}' can't be converted to string")};
         }
     }