Fixed WithLocation on SchemaDefinitionNode (#4964)

ChilliCream · Apr 13, 2022 · dfe0a4d · dfe0a4d
1 parent a5d4be3
commit dfe0a4d
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/src/HotChocolate/Language/src/Language.SyntaxTree/OptionalModifierNode.cs b/src/HotChocolate/Language/src/Language.SyntaxTree/OptionalModifierNode.cs
@@ -111,7 +111,7 @@ public override bool Equals(object? obj)
     /// hashing algorithms and data structures such as a hash table.
     /// </returns>
     public override int GetHashCode()
-       => HashCode.Combine(Kind, Element?.GetHashCode());
+       => HashCode.Combine(Kind, Element);
 
     public static bool operator ==(
         OptionalModifierNode? left,

diff --git a/src/HotChocolate/Language/src/Language.SyntaxTree/ScalarTypeDefinitionNode.cs b/src/HotChocolate/Language/src/Language.SyntaxTree/ScalarTypeDefinitionNode.cs
@@ -7,7 +7,7 @@ namespace HotChocolate.Language;
 /// <summary>
 /// <para>Represents the scalar definition syntax.</para>
 /// <para>
-/// Scalar types represent primitive leaf values in a GraphQL type system. 
+/// Scalar types represent primitive leaf values in a GraphQL type system.
 /// GraphQL responses take the form of a hierarchical tree;
 /// the leaves of this tree are typically GraphQL Scalar types
 /// (but may also be Enum types or null values).
@@ -182,7 +182,7 @@ public override bool Equals(object? obj)
     /// hashing algorithms and data structures such as a hash table.
     /// </returns>
     public override int GetHashCode()
-       => HashCode.Combine(base.GetHashCode(), Kind, Description?.GetHashCode());
+       => HashCode.Combine(base.GetHashCode(), Kind, Description);
 
     /// <summary>
     /// The equal operator.

diff --git a/src/HotChocolate/Language/src/Language.SyntaxTree/SchemaDefinitionNode.cs b/src/HotChocolate/Language/src/Language.SyntaxTree/SchemaDefinitionNode.cs
@@ -63,7 +63,7 @@ public IEnumerable<ISyntaxNode> GetNodes()
     public SchemaDefinitionNode WithLocation(Location? location)
     {
         return new SchemaDefinitionNode(
-            Location, Description, Directives, OperationTypes);
+            location, Description, Directives, OperationTypes);
     }
 
     public SchemaDefinitionNode WithDirectives(

diff --git a/src/HotChocolate/Language/src/Language.SyntaxTree/SchemaExtensionNode.cs b/src/HotChocolate/Language/src/Language.SyntaxTree/SchemaExtensionNode.cs
@@ -54,7 +54,7 @@ public IEnumerable<ISyntaxNode> GetNodes()
     public SchemaExtensionNode WithLocation(Location? location)
     {
         return new SchemaExtensionNode(
-            Location, Directives, OperationTypes);
+            location, Directives, OperationTypes);
     }
 
     public SchemaExtensionNode WithDirectives(

diff --git a/src/HotChocolate/Language/src/Language.SyntaxTree/SelectionSetNode.cs b/src/HotChocolate/Language/src/Language.SyntaxTree/SelectionSetNode.cs
@@ -77,8 +77,7 @@ public SelectionSetNode WithLocation(Location? location)
             throw new ArgumentNullException(nameof(selection));
         }
 
-        var selections = new List<ISelectionNode>(Selections);
-        selections.Add(selection);
+        var selections = new List<ISelectionNode>(Selections) { selection };
 
         return new SelectionSetNode(
             Location, selections);