Changes Add(IExecutionResult) to AddResult for Snapshot tests #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@michaelstaib @PascalSenn swapping the SnapshotExtensions.Add calls to snapshot.AddResult using method chaining, Rider has applied this not just to this usage but all situations where the static method call can be swapped. Should I wind this back? |
| var empty = TypeConverterExtensions.Convert<object, Guid>( | ||
| DefaultTypeConverter.Default, | ||
| null); | ||
| var empty = DefaultTypeConverter.Default.Convert<object, Guid>(null); |
There was a problem hiding this comment.
In unit tests we need to be explicit. So this needs to be reverted.
| @@ -11,31 +11,27 @@ public class PagingObjectFieldDescriptorExtensionsTests | |||
| public static void ObjectFieldDescriptor_UseOffsetPaging_Descriptor_Is_Null() | |||
| { | |||
| Assert.Throws<ArgumentNullException>( | |||
| () => PagingObjectFieldDescriptorExtensions.UsePaging( | |||
| default(IObjectFieldDescriptor)!)); | |||
| () => default(IObjectFieldDescriptor)!.UsePaging()); | |||
matt-psaltis
force-pushed
the
mp/snapshot-addresult
branch
from
e3347b5
to
e05bad5
Compare
michaelstaib
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames Snapshot Add extension method to AddResult