Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: Strawberry Shake Tooling download command does not send scope(s) to token endpoint. #5340

Merged
merged 3 commits into from Aug 29, 2022
Merged

Fixes: Strawberry Shake Tooling download command does not send scope(s) to token endpoint. #5340

merged 3 commits into from Aug 29, 2022

Conversation

charristti
Copy link
Contributor

@charristti charristti commented Aug 24, 2022 •
edited by michaelstaib

  • reversed the order of the ternary conditional operation so that when scopes are provided they are passed on to the call tothe oauth endpoint

Closes #5319

@charristti
Issue ChilliCream#5319
9328348 
Scopes are not processed properly when provided on the command line
@CLAassistant
Copy link

CLAassistant commented Aug 24, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@michaelstaib
Copy link
Member

@charristti thank you for your contribution. Could you sign the CLA so we can go forward with the PR?

https://cla-assistant.io/ChilliCream/hotchocolate?pullRequest=5340

@michaelstaib michaelstaib self-requested a review August 24, 2022 21:32
@michaelstaib michaelstaib changed the title Issue #5319 Fixes: Strawberry Shake Tooling download command does not send scope(s) to token endpoint. Aug 24, 2022
@michaelstaib
Copy link
Member

@charristti can you sign the CLA?

https://cla-assistant.io/ChilliCream/hotchocolate?pullRequest=5340

@charristti
Copy link
Contributor Author

charristti commented Aug 27, 2022 via email

@charristti charristti changed the title Fixes: Strawberry Shake Tooling download command does not send scope(s) to token endpoint. Fixes: Strawberry Shake Tooling download command does not send scope(s) to token endpoint.xx Aug 27, 2022
@charristti charristti changed the title Fixes: Strawberry Shake Tooling download command does not send scope(s) to token endpoint.xx Fixes: Strawberry Shake Tooling download command does not send scope(s) to token endpoint. Aug 27, 2022
@charristti
Copy link
Contributor Author

charristti shows signed now. Can you tell me how to fix the “Chuck Harris” problem?

@michaelstaib michaelstaib merged commit 2123107 into ChilliCream:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees
No one assigned
Labels
🌶️ strawberry shake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strawberry Shake Tooling download command does not send scope(s) to token endpoint
3 participants
@charristti @CLAassistant @michaelstaib