Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify completion of subscription to storeless client #5469

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Notify completion of subscription to storeless client #5469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb2c76d
Generate a test with noStore subscription
sunghwan2789 Oct 7, 2022
3397e6e
Add test
sunghwan2789 Oct 7, 2022
0fdc52d
Notify completion of subscription to storeless client
sunghwan2789 Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/StrawberryShake/Client/src/Core/StorelessOperationExecutor.Observable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ public IDisposable Subscribe(IObserver<IOperationResult<TResult>> observer)
}
finally
{
// call observer's OnCompleted method to notify observer
// there is no further data is available.
observer.OnCompleted();

// after all the transport logic is finished we will dispose
// the request session.
session.RequestSession.Dispose();
Expand Down