Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ServiceKind.Resolver not working with ResolveWith #5677

Merged
merged 3 commits into from Jan 12, 2023

Conversation

tobias-tengler
Copy link
Collaborator

@tobias-tengler tobias-tengler commented Jan 12, 2023

Fixes #4945

@michaelstaib michaelstaib changed the title Add test for ServiceKind.Resolver not working with ResolveWith Fixed ServiceKind.Resolver not working with ResolveWith Jan 12, 2023
@michaelstaib michaelstaib self-requested a review January 12, 2023 10:05
@michaelstaib michaelstaib marked this pull request as ready for review January 12, 2023 10:05
@michaelstaib michaelstaib merged commit 195d446 into main Jan 12, 2023
@michaelstaib michaelstaib deleted the tte/resolver-service-resolve-with branch January 12, 2023 10:07
tobias-tengler added a commit that referenced this pull request Jan 12, 2023
Co-authored-by: Michael Staib <michael@chillicream.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServiceKind isn't correctly respected by resolvers added to field descriptors using the code-first approach
2 participants