Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update command not updating schema file #6016

Merged
merged 1 commit into from Apr 4, 2023
Merged

Fix update command not updating schema file #6016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/StrawberryShake/Tooling/src/dotnet-graphql/UpdateCommandHandler.cs
View file
Open in desktop
Expand Up @@ -107,6 +107,10 @@ await arguments.AuthArguments
// the user can still work.
if (!await DownloadSchemaAsync(context, uri, tempFile, cancellationToken)
.ConfigureAwait(false))
{
hasErrors = true;
}
else
{
// if the schema download succeeded we will replace the old schema with the
// new one.
Expand All @@ -116,8 +120,6 @@ await arguments.AuthArguments
}

File.Move(tempFile, schemaFilePath);

hasErrors = true;
}

// in any case we will make sure the temp file is removed at the end.
Expand Down