Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #6067

Merged
merged 4 commits into from Apr 22, 2023
Merged

Fix broken links #6067

merged 4 commits into from Apr 22, 2023

Conversation

wilmerferreira
Copy link
Contributor

@wilmerferreira wilmerferreira commented Apr 18, 2023

This contains fixes for broken links in docs

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added 🌶️ website 📚 documentation This issue is about working on our documentation. labels Apr 18, 2023
Copy link
Collaborator

@tobias-tengler tobias-tengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the links, but the <PackageInstallation ...s you marked as code are actual React components being displayed on the Website. Marking them as code would be wrong. I understand that this is suboptimal for people viewing the raw markdown files. Do you know of any mechanism to fallback to text for raw markdown?

@wilmerferreira
Copy link
Contributor Author

Interesting... what I could do is undo those, investigate how to handle them and fix them in a separate PR

@wilmerferreira
Copy link
Contributor Author

Removed changes around React components

@wilmerferreira
Copy link
Contributor Author

wilmerferreira commented Apr 19, 2023

@tobias-tengler How can I trigger the HotChocolate-CI and WebSite-CI?

@wilmerferreira wilmerferreira changed the title Fix broken links and hidden references Fix broken links Apr 19, 2023
@michaelstaib michaelstaib merged commit 51be0dc into ChilliCream:main Apr 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation This issue is about working on our documentation. 🌶️ website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants