Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrawberryShake: remove temp directory after update #6186

Merged
merged 2 commits into from
May 23, 2023

Conversation

jorrit
Copy link
Contributor

@jorrit jorrit commented May 23, 2023

Fixes #6184

This change removes the temporary directory created by dotnet graphql update.
Another solution would be to not use a temporary directory at all, but just write to the base temp directory, perhaps leveraging something like Path.GetTempFileName().

@michaelstaib
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@michaelstaib michaelstaib added this to the HC-13.1.1 milestone May 23, 2023
@michaelstaib michaelstaib self-requested a review May 23, 2023 11:15
@michaelstaib
Copy link
Member

Thank you for your help!

@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@michaelstaib michaelstaib merged commit 6989145 into ChilliCream:main May 23, 2023
5 checks passed
@michaelstaib michaelstaib modified the milestones: HC-13.1.1, HC-13.2.0 Jun 1, 2023
This was referenced Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet graphql leaves temp directory
2 participants