Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress compiler warnings in auto-generated code #6474

Merged
merged 10 commits into from
Jun 5, 2024

Conversation

VaclavSir
Copy link
Contributor

Disabling compiler warning CS1591 (missing XML comment) in the generated code.

Closes #5987

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@9c68057). Learn more about missing BASE report.

Current head 3a97624 differs from pull request most recent head 2bf5a17

Please upload reports for the commit 2bf5a17 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6474   +/-   ##
=======================================
  Coverage        ?   63.45%           
=======================================
  Files           ?     2324           
  Lines           ?   114629           
  Branches        ?        0           
=======================================
  Hits            ?    72739           
  Misses          ?    41890           
  Partials        ?        0           
Flag Coverage Δ
unittests 63.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VaclavSir VaclavSir force-pushed the suppress-warning-CS1591 branch 2 times, most recently from e6c32b8 to 05187b1 Compare August 26, 2023 06:16
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@glen-84
Copy link
Collaborator

glen-84 commented Jan 14, 2024

This seems okay. The alternatives would be:

@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@michaelstaib
Copy link
Member

can we change this to ignore any warning?

#pragma warning disable

@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@glen-84 glen-84 changed the title Suppress compiler warning in auto-generated code Suppress compiler warnings in auto-generated code Jun 5, 2024
@michaelstaib michaelstaib merged commit 899be4f into ChilliCream:main Jun 5, 2024
8 checks passed
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress warning CS1591: Missing XML comment in autogenerated code
4 participants