Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CookieCrumble to abstract test frameworks #6537

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Merge branch 'main' into feat/refactor-into-test-frameworks

a60783e
Select commit
Loading
Failed to load commit list.
Open

Refactor CookieCrumble to abstract test frameworks #6537

Merge branch 'main' into feat/refactor-into-test-frameworks
a60783e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 14, 2023 in 0s

78.87% (-0.12%) compared to 6965960

View this Pull Request on Codecov

78.87% (-0.12%) compared to 6965960

Details

Codecov Report

Patch coverage: 57.77% and project coverage change: -0.12% ⚠️

Comparison is base (6965960) 78.98% compared to head (a60783e) 78.87%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6537      +/-   ##
==========================================
- Coverage   78.98%   78.87%   -0.12%     
==========================================
  Files        2903     2917      +14     
  Lines      139771   140402     +631     
==========================================
+ Hits       110397   110740     +343     
- Misses      29374    29662     +288     
Files Changed Coverage Δ
...ocolate/Fusion/src/Core/Execution/Nodes/Resolve.cs 78.33% <12.50%> (-10.35%) ⬇️
...sion/src/Core/Execution/Nodes/ResolveByKeyBatch.cs 69.30% <12.50%> (-2.34%) ⬇️
...Types/Resolvers/DirectiveClassMiddlewareFactory.cs 62.50% <75.00%> (+44.31%) ⬆️
src/CookieCrumble/src/CookieCrumble/Snapshot.cs 77.74% <80.95%> (ø)
...rc/Core/Metadata/FusionGraphConfigurationReader.cs 94.04% <100.00%> (+0.90%) ⬆️

... and 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.